Page MenuHomePhabricator

[openmp] Use config.test_extra_flags in archer and multiplex tests
ClosedPublic

Authored by zhuhan0 on Jun 24 2020, 5:58 PM.

Details

Summary

config.test_extra_flags is passed in from lit.site.cfg.in files, but they're not used in the LIT configs. This variable can be useful for distros which don't have the standard c/c++ headers in the default search paths. Since the tests run clang on c/c++ source code, we rely on test_extra_flags to pass in the necessary header files.

This is a similar setup that's also done in litomptarget https://github.com/llvm/llvm-project/blob/master/openmp/libomptarget/test/lit.cfg#L42 and openmp/runtime.

Diff Detail

Event Timeline

zhuhan0 created this revision.Jun 24 2020, 5:58 PM
zhuhan0 edited the summary of this revision. (Show Details)Jun 24 2020, 6:08 PM
zhuhan0 added reviewers: jdenny, protze.joachim.
This revision is now accepted and ready to land.Jun 24 2020, 10:06 PM

Thanks @jdoerfert! I don't yet have commit access. Could you commit this for me?

Eventually, I'm pretty booked the next few days. Maybe @protze.joachim finds the time.

wenlei added a subscriber: wenlei.Jun 25 2020, 12:14 PM

@zhuhan0 thanks for the fix - I just pushed the change on your behalf.

This revision was automatically updated to reflect the committed changes.