Page MenuHomePhabricator

Remove references to the 4.0 release as a major breaking (NFC)
ClosedPublic

Authored by mehdi_amini on Wed, Jun 24, 5:51 PM.

Details

Summary

This is cleaning up comments (mostly in the bitcode handling) about
removing some backward compatibility aspect in the 4.0 release.
Historically, "4.0" was used during the development of the 3.x
versions as "this future major breaking change version". At the time
the major number was used to indicate the compatibility. When we
reached 3.9 we decided to change the numbering, instead of going to
3.10 we went to 4.0 but after changing the meaning of the major
number to not mean anything anymore with respect to bitcode backward
compatibility.

The current policy
(https://llvm.org/docs/DeveloperPolicy.html#ir-backwards-compatibility)
indicates only now:

The current LLVM version supports loading any bitcode since version 3.0.

Diff Detail

Event Timeline

mehdi_amini created this revision.Wed, Jun 24, 5:51 PM
Herald added a project: Restricted Project. · View Herald Transcript

Do we want to actually do the breaking release?

Alternately we should probably use the deprecated part on DataLayout as well :)

-eric

Do we want to actually do the breaking release?

I don't think so?

Alternately we should probably use the deprecated part on DataLayout as well :)

I didn't quite get that?

Do we want to actually do the breaking release?

I don't think so?

I didn't either, but thought I'd ask :)

Alternately we should probably use the deprecated part on DataLayout as well :)

I didn't quite get that?

Oh, you removed a fixme in DataLayout.cpp.

dexonsmith accepted this revision.Thu, Jun 25, 2:13 PM

This LGTM, assuming @echristo is happy.

llvm/lib/IR/DataLayout.cpp
262–264

I think @echristo is suggesting updating this comment to match the new ones elsewhere ("Deprecated, but ...").

This revision is now accepted and ready to land.Thu, Jun 25, 2:13 PM
echristo accepted this revision.Thu, Jun 25, 2:46 PM

I'm happy with this as well - my only comment was the one Duncan pointed out :)

llvm/lib/IR/DataLayout.cpp
262–264

I was yes :)

mehdi_amini marked an inline comment as done.Thu, Jun 25, 2:53 PM
mehdi_amini added inline comments.
llvm/lib/IR/DataLayout.cpp
262–264

Ah OK.

This isn't bitcode related though: we have a few occurrences of these in the LL parser as well that I didn't touch. I don't think there is a policy on these, what should I write? // Deprecated, but ignoring here to preserve loading older textual llvm ASM file ?

echristo added inline comments.Thu, Jun 25, 3:41 PM
llvm/lib/IR/DataLayout.cpp
262–264

Works for me :)

This revision was automatically updated to reflect the committed changes.