Using fully qualified names wherever possible avoids ambiguous class and function names. This is a follow-up to D82371.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
mlir/include/mlir/IR/OpBase.td | ||
---|---|---|
220 | Please go through and make sure everything is wrapped at 80 characters. |
Comment Actions
I'm wondering how hard it would be to have a linter check for TableGen files that reports whether there are lines longer than 80 characters. This could be useful for such situations: I had to change some locations in OpBase.td that went unnoticed during earlier reviews (e.g. the constBuilderCall for I32EnumAttr).
Comment Actions
LGTM after making sure that LLVM types use the proper llvm namespace.
mlir/tools/mlir-tblgen/PassGen.cpp | ||
---|---|---|
45 | Please use the proper definition in LLVM for LLVM types. |
Please go through and make sure everything is wrapped at 80 characters.