Page MenuHomePhabricator

[X86] Replace PROC macros with an enum and a lookup table of processor information.
ClosedPublic

Authored by craig.topper on Jun 23 2020, 2:56 PM.

Details

Summary

This patch removes the PROC macro in favor of CPUKind enum and a
table contains information about CPUs.

The current information in the table is the CPU name, CPUKind enum
value, key feature for target multiversioning, and Is64Bit capable.
For the strings that are aliases, I've duplicated the information
in the table. This means there are more rows in the table than
CPUKind enums.

This replaces multiple StringSwitch's with loops through the table.
They are linear searches due to the table being more logically
ordered than alphabetical. The StringSwitch's would have also been
linear. I've used StringLiteral on the strings in the table so we
can quickly check the length while searching.

I contemplated having a CPUKind for each string so there was a 1:1
mapping, but didn't want to spread more names to the places that
use the enum.

My ultimate goal here is to store the features for each CPU as a
bitset within the table. Hoping to use constexpr to make this
composable so we can group features and inherit them. After the
table lookup we can turn the bitset into a list of strings for the
frontend. The current switch we have for selecting features for
CPUs has become difficult to maintain while trying to express
inheritance relationships.

Diff Detail

Event Timeline

craig.topper created this revision.Jun 23 2020, 2:56 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptJun 23 2020, 2:56 PM
Herald added a subscriber: hiraditya. · View Herald Transcript
craig.topper marked an inline comment as done.
craig.topper added inline comments.
llvm/lib/Support/X86TargetParser.cpp
36

Once we have feature bits in the table the PROC_32_BIT/PROC_64_BIT can just check FEATURE_EM64T.

erichkeane accepted this revision.Jun 24 2020, 6:07 AM

1 nit, plus the clang-tidy suggestions.

clang/lib/Basic/Targets/X86.cpp
1559

static-cast?

This revision is now accepted and ready to land.Jun 24 2020, 6:07 AM
This revision was automatically updated to reflect the committed changes.