This is an archive of the discontinued LLVM Phabricator instance.

Differential D82413

[mlir] [integration-test] Let target check-mlir imply target check-mlir-integration too
ClosedPublic

Authored by aartbik on Jun 23 2020, 2:26 PM.

Details

Reviewers
mehdi_amini
jpienaar
Commits
rGba690195d1c6: [mlir] [integration-test] Let target check-mlir imply target check-mlir…
Summary

Note that this does not mean that check-mlir will run check-mlir-integration
tests for all configurations. You still need to do a set up with the flag
MLIR_INCLUDE_INTEGRATION_TESTS set to ON in order to activate the integration test.

Diff Detail

Event Timeline

aartbik created this revision.Jun 23 2020, 2:26 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 23 2020, 2:26 PM
Herald added subscribers: msifontes, jurahul, Kayjukh and 14 others. · View Herald Transcript
aartbik added reviewers: mehdi_amini, jpienaar.Jun 23 2020, 2:27 PM
jpienaar added a comment.Jun 23 2020, 2:47 PM

Looks good, I'd add what you have in the change description to the CMake file (re: only if MLIR_INCLUDE_INTEGRATION_TESTS is set to on)

aartbik added a comment.Jun 23 2020, 2:55 PM
In D82413#2110098, @jpienaar wrote:

Looks good, I'd add what you have in the change description to the CMake file (re: only if MLIR_INCLUDE_INTEGRATION_TESTS is set to on)

Sounds like a good idea. Done.

aartbik updated this revision to Diff 272836.Jun 23 2020, 2:56 PM

addressed feedback on adding comment

jpienaar accepted this revision.Jun 23 2020, 2:58 PM
This revision is now accepted and ready to land.Jun 23 2020, 2:58 PM
Harbormaster failed remote builds in B61458: Diff 272830!Jun 23 2020, 3:39 PM
Closed by commit rGba690195d1c6: [mlir] [integration-test] Let target check-mlir imply target check-mlir… (authored by aartbik). · Explain WhyJun 23 2020, 3:39 PM
This revision was automatically updated to reflect the committed changes.
Harbormaster failed remote builds in B61459: Diff 272836!Jun 23 2020, 4:11 PM

Revision Contents

PathSize
mlir/
integration_test/
4 lines

Diff 272850

mlir/integration_test/CMakeLists.txt

Show All 15 Linesconfigure_lit_site_cfg(
) )
add_lit_testsuite(check-mlir-integration "Running the MLIR integration tests" add_lit_testsuite(check-mlir-integration "Running the MLIR integration tests"
${CMAKE_CURRENT_BINARY_DIR} ${CMAKE_CURRENT_BINARY_DIR}
DEPENDS ${MLIR_INTEGRATION_TEST_DEPENDS} DEPENDS ${MLIR_INTEGRATION_TEST_DEPENDS}
) )
set_target_properties(check-mlir-integration PROPERTIES FOLDER "integration_test") set_target_properties(check-mlir-integration PROPERTIES FOLDER "integration_test")
# Let target "check-mlir" imply the target "check-mlir-integration" as well,
# provided that MLIR_INCLUDE_INTEGRATION_TESTS=ON during the initial setup.
add_dependencies(check-mlir check-mlir-integration)
add_lit_testsuites(MLIR_INTEGRATION ${CMAKE_CURRENT_SOURCE_DIR} add_lit_testsuites(MLIR_INTEGRATION ${CMAKE_CURRENT_SOURCE_DIR}
DEPENDS ${MLIR_INTEGRATION_TEST_DEPENDS} DEPENDS ${MLIR_INTEGRATION_TEST_DEPENDS}
) )