Page MenuHomePhabricator

[mlir] Support iterator arguments in the loop unrolling
Needs RevisionPublic

Authored by liufengdb on Tue, Jun 23, 1:17 PM.

Details

Diff Detail

Event Timeline

liufengdb created this revision.Tue, Jun 23, 1:17 PM
Herald added a project: Restricted Project. · View Herald TranscriptTue, Jun 23, 1:17 PM
rriddle added inline comments.Tue, Jun 23, 1:29 PM
mlir/lib/Transforms/Utils/LoopUtils.cpp
488

Use ValueRange instead of ArrayRefs here, it removes the need to create a smallvector below.

liufengdb updated this revision to Diff 272861.Tue, Jun 23, 4:32 PM

fix some test failures

liufengdb updated this revision to Diff 272864.Tue, Jun 23, 4:34 PM

remove the redundant comments

liufengdb updated this revision to Diff 272865.Tue, Jun 23, 4:36 PM

remove unused

ftynse requested changes to this revision.Wed, Jun 24, 6:06 AM
ftynse added inline comments.
mlir/lib/Transforms/Utils/LoopUtils.cpp
483

Can this use ValueRange instead of ArrayRef?

503

Nit: camelCase please

504

lookupOrDefault(terminator->getOperand(..)) will remove the need for if below

511

Can we just bail out of transformation in this case, instead of producing incorrect code?

mlir/test/Dialect/SCF/loop-unroll.mlir
263

Let's not pattern-match SSA value names

This revision now requires changes to proceed.Wed, Jun 24, 6:06 AM
bondhugula requested changes to this revision.Wed, Jun 24, 9:35 AM
bondhugula added a subscriber: bondhugula.

@liufengdb Can you add a commit summary please even if brief?