This patch add support for 'spv.CopyMemory'. The following changes are
introduced:
- 'CopyMemory' op is added to SPIRVOps.td.
- Custom parse and print methods are introduced.
- A few Roundtripping tests are added.
Paths
| Differential D82384
[MLIR][SPIRV] Add support for OpCopyMemory. ClosedPublic Authored by ergawy on Jun 23 2020, 7:43 AM.
Details Summary This patch add support for 'spv.CopyMemory'. The following changes are
Diff Detail
Event Timelineergawy added inline comments.
ergawy added inline comments.
ergawy added inline comments.
Comment Actions
ergawy added inline comments.
This revision is now accepted and ready to land.Jun 26 2020, 6:37 AM
Closed by commit rGd6485ed3a770: [MLIR][SPIRV] Add support for OpCopyMemory. (authored by ergawy, committed by antiagainst). · Explain WhyJun 26 2020, 7:03 AM This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 273332 mlir/include/mlir/Dialect/SPIRV/SPIRVBase.td
mlir/include/mlir/Dialect/SPIRV/SPIRVOps.td
mlir/lib/Dialect/SPIRV/SPIRVOps.cpp
mlir/test/Dialect/SPIRV/Serialization/memory-ops.mlir
mlir/test/Dialect/SPIRV/ops.mlir
|
According to the spec: https://www.khronos.org/registry/spir-v/specs/unified1/SPIRV.html#OpCopyMemory, the op supports up to 2 memory access operands. However, I still don't know how to model this in ODS.