This is an archive of the discontinued LLVM Phabricator instance.

Fix bad doxygen result for class clang::ento::CallEvent and its derived classes
ClosedPublic

Authored by OikawaKirie on Jun 23 2020, 12:40 AM.

Details

Summary

Fix bug https://bugs.llvm.org/show_bug.cgi?id=44753. This patch is a workaround of a Doxygen bug, so that it can correctly generate documents for class clang::ento::CallEvent and its derived classes.

Diff Detail

Event Timeline

OikawaKirie created this revision.Jun 23 2020, 12:40 AM
NoQ accepted this revision.Jun 23 2020, 2:15 AM
NoQ edited reviewers, added: NoQ, vsavchenko; removed: dergachev.a, jordan_rose.
NoQ added a subscriber: NoQ.

Nice catch, looks like block calls are indeed not present in doxygen.
Thanks, i'll commit!

This revision is now accepted and ready to land.Jun 23 2020, 2:15 AM

@vsavchenko @dcoughlin @NoQ
I do not know whether it is correct to ping somebody like this. As this is my first submitted review, I do not know what should I do next, when the patch has been accepted by one of the reviewers while others have not given any comments. Should I continue waiting for other reviewers? And what should I do with the bug report (https://bugs.llvm.org/show_bug.cgi?id=44753)?
Thank you.

vsavchenko accepted this revision.Jul 13 2020, 1:45 AM

Should I continue waiting for other reviewers?

Whoops, sorry for that, I'll commit it for you!

And what should I do with the bug report (https://bugs.llvm.org/show_bug.cgi?id=44753)?

You can close it after the patch is on master.

Thanks!

@OikawaKirie One last thing, what's your preferred name and email for the commit? Thanks!

@vsavchenko Ella Ma <alansnape3058@gmail.com>. Thank you.

This revision was automatically updated to reflect the committed changes.
NoQ added a comment.Jul 13 2020, 4:44 PM

Sorry!! I was sure i pushed this. Thank you Valeriy.