Page MenuHomePhabricator

OikawaKirie (Ella Ma)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 22 2020, 11:10 PM (23 w, 3 d)

Recent Activity

Today

OikawaKirie added a comment to D92639: [analyzer] Add control flow arrows to the analyzer's HTML reports.

It is really a good idea!

Fri, Dec 4, 1:48 AM · Restricted Project

Thu, Nov 26

OikawaKirie requested review of D92160: [clang] Fix wrong FDs are used for files with same name in Tooling.
Thu, Nov 26, 2:12 AM · Restricted Project

Mon, Nov 23

OikawaKirie added a comment to D91960: [llvm][unittests] Fix protential nullptr dereferences due to unchecked return value or EXPECT_* macro.

Some of my fixes still need to be improved (see the comments in the code). If any reviewers have better ideas, I will update the patch.

Mon, Nov 23, 5:15 AM · Restricted Project
OikawaKirie requested review of D91960: [llvm][unittests] Fix protential nullptr dereferences due to unchecked return value or EXPECT_* macro.
Mon, Nov 23, 5:04 AM · Restricted Project

Sun, Nov 22

OikawaKirie added a comment to D91844: [llvm][clang] Add checks for the smart pointers with the possibility to be null.

Is it possible to split these up into separate patches for unrelated code?

Sun, Nov 22, 7:11 PM · Restricted Project, Restricted Project

Thu, Nov 19

OikawaKirie requested review of D91844: [llvm][clang] Add checks for the smart pointers with the possibility to be null.
Thu, Nov 19, 11:35 PM · Restricted Project, Restricted Project
OikawaKirie updated the diff for D91410: [llvm][clang][mlir] Add checks for the return values from Target::createXXX to prevent protential null deref.
  1. Replace fatal errors with assertions.
Thu, Nov 19, 8:08 PM · Restricted Project, Restricted Project, Restricted Project

Tue, Nov 17

OikawaKirie added a comment to D91410: [llvm][clang][mlir] Add checks for the return values from Target::createXXX to prevent protential null deref.
Tue, Nov 17, 10:32 PM · Restricted Project, Restricted Project, Restricted Project

Mon, Nov 16

OikawaKirie requested review of D91540: [preprocessor] Assertions on the inferrable null pointers in Preprocessor befere dereference.
Mon, Nov 16, 6:36 AM · Restricted Project

Fri, Nov 13

OikawaKirie requested review of D91410: [llvm][clang][mlir] Add checks for the return values from Target::createXXX to prevent protential null deref.
Fri, Nov 13, 3:32 AM · Restricted Project, Restricted Project, Restricted Project

Oct 22 2020

OikawaKirie added a comment to D89987: [analyzer] [NFC] Rename SymbolRef to SymExprRef.

Since SymbolRef is just a const SymExpr * in the current codebase, I'd prefer using const SymExpr * directly, just like how MemRegion is used, which would be clearer than both SymbolRef and SymExprRef as far as I am thinking.

Oct 22 2020, 8:09 PM · Restricted Project

Oct 15 2020

OikawaKirie abandoned D88198: Hints CMake where to find Z3 with LLVM_Z3_INSTALL_DIR..

Yes, it's being used in the FindZ3.cmaks script.

Oct 15 2020, 7:30 PM · Restricted Project
OikawaKirie added a comment to D88198: Hints CMake where to find Z3 with LLVM_Z3_INSTALL_DIR..

I have another try in a newly installed system without Z3 installed from the distribute software source, and the following tests are carried out in /tmp/ella.z3-patch.

Oct 15 2020, 4:25 AM · Restricted Project

Oct 11 2020

OikawaKirie added a comment to D88198: Hints CMake where to find Z3 with LLVM_Z3_INSTALL_DIR..

@mikhail.ramalho ping

Oct 11 2020, 7:26 PM · Restricted Project

Sep 23 2020

OikawaKirie requested review of D88198: Hints CMake where to find Z3 with LLVM_Z3_INSTALL_DIR..
Sep 23 2020, 8:49 PM · Restricted Project

Sep 9 2020

OikawaKirie added a comment to D83660: [analyzer] Fix a crash for dereferencing an empty llvm::Optional variable in SMTConstraintManager.h..

After reviewing the code of this snippet, I think it would be very difficult to make a regression test case for the crash, as far as what I know about Z3 and SMT solvers.

Sep 9 2020, 11:11 PM · Restricted Project

Sep 8 2020

OikawaKirie added a comment to D83660: [analyzer] Fix a crash for dereferencing an empty llvm::Optional variable in SMTConstraintManager.h..

We have tried to trigger the crash with the original project where the crash was encountered. But the problem is we cannot trigger the crash with the project, and we have lost all the previous records about this crash. Besides, both I and the bug reporter himself are now working on our own research right now. We have very limited time working on this patch in recent months. We are now planning to just make a simple regression test case to trigger the crash during our spire time. Sorry for the delay.

Sep 8 2020, 8:55 PM · Restricted Project

Aug 23 2020

OikawaKirie added a comment to D85105: [doxygen] Fix bad doxygen results for BugReporterVisitors.h.

@vsavchenko @NoQ
The patch has been updated as required. Is there anything I need to do with the patch?

Aug 23 2020, 8:07 PM · Restricted Project

Aug 12 2020

OikawaKirie updated the diff for D85105: [doxygen] Fix bad doxygen results for BugReporterVisitors.h.

Ok, I got it. I will pay attention to this in the future submits.

Aug 12 2020, 12:35 AM · Restricted Project

Aug 11 2020

OikawaKirie updated the diff for D85105: [doxygen] Fix bad doxygen results for BugReporterVisitors.h.

Now it has a link to the getEndPath.

Aug 11 2020, 7:22 PM · Restricted Project

Aug 2 2020

OikawaKirie requested review of D85105: [doxygen] Fix bad doxygen results for BugReporterVisitors.h.
Aug 2 2020, 10:05 PM · Restricted Project

Jul 14 2020

OikawaKirie added a comment to D83660: [analyzer] Fix a crash for dereferencing an empty llvm::Optional variable in SMTConstraintManager.h..

Might in the future I would spend some time on it - we will see.

@steakhal My boss always asks me about how to improve the performance for SMT solver based constraint solving, on both the engine side and the SMT solver side. If there is anything that our research group can do, you are free to contact us.

BTW nice catch & fix.

Thank you. This crash was discovered by one of our team members when we were testing our CSA based tool. If the patch gets merged in the future, I'd like to use his name and email for the commit.

Jul 14 2020, 1:09 AM · Restricted Project
OikawaKirie added a comment to D83660: [analyzer] Fix a crash for dereferencing an empty llvm::Optional variable in SMTConstraintManager.h..

do you accidentally have a test case to reproduce the crash

@NoQ I am now working with the reporter of this bug to make a simple test case to trigger the crash.

Jul 14 2020, 12:46 AM · Restricted Project

Jul 13 2020

OikawaKirie added a comment to D82356: Fix bad doxygen result for class clang::ento::CallEvent and its derived classes.

@vsavchenko Ella Ma <alansnape3058@gmail.com>. Thank you.

Jul 13 2020, 2:01 AM · Restricted Project
OikawaKirie created D83660: [analyzer] Fix a crash for dereferencing an empty llvm::Optional variable in SMTConstraintManager.h..
Jul 13 2020, 12:52 AM · Restricted Project
OikawaKirie added a comment to D82356: Fix bad doxygen result for class clang::ento::CallEvent and its derived classes.

@vsavchenko @dcoughlin @NoQ
I do not know whether it is correct to ping somebody like this. As this is my first submitted review, I do not know what should I do next, when the patch has been accepted by one of the reviewers while others have not given any comments. Should I continue waiting for other reviewers? And what should I do with the bug report (https://bugs.llvm.org/show_bug.cgi?id=44753)?
Thank you.

Jul 13 2020, 12:28 AM · Restricted Project

Jun 23 2020

OikawaKirie created D82356: Fix bad doxygen result for class clang::ento::CallEvent and its derived classes.
Jun 23 2020, 1:00 AM · Restricted Project