LowerConstantIntrinsics fails to preserve the analysis result of GlobalsAA. Not preserving the analysis might affect benchmark performance. This change fixes this issue.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
LGTM. LowerConstantIntrinsics should not modify globals and can preserve GlobalsAA. This is also in line with what we currently do in many other passes and not preserving GlobalsAA can lead to serious performance regressions.
I can commit this patch for you in a day or so, to give other people a chance to chime in as well.