Page MenuHomePhabricator

rsanthir.quic (Ryan Santhirarajan)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 17 2020, 3:40 PM (51 w, 4 d)

Recent Activity

Wed, Jun 9

rsanthir.quic added inline comments to D102782: Add support for Warning Flag "-Wstack-usage=".
Wed, Jun 9, 3:17 PM · Restricted Project
rsanthir.quic added a comment to D102782: Add support for Warning Flag "-Wstack-usage=".

@bruno all tests are passing, could you take another look when you have a chance?

Wed, Jun 9, 8:18 AM · Restricted Project

Wed, Jun 2

rsanthir.quic added a comment to D102782: Add support for Warning Flag "-Wstack-usage=".

ping

Wed, Jun 2, 9:33 AM · Restricted Project
rsanthir.quic updated the diff for D102782: Add support for Warning Flag "-Wstack-usage=".

Updated Release Notes and rebased

Wed, Jun 2, 8:01 AM · Restricted Project

Fri, May 28

rsanthir.quic updated the diff for D102782: Add support for Warning Flag "-Wstack-usage=".

Updated test and aligned negative flag with gcc

Fri, May 28, 11:49 AM · Restricted Project
rsanthir.quic updated the diff for D102782: Add support for Warning Flag "-Wstack-usage=".

Updated test

Fri, May 28, 10:36 AM · Restricted Project
rsanthir.quic updated the diff for D102782: Add support for Warning Flag "-Wstack-usage=".

rebase

Fri, May 28, 8:10 AM · Restricted Project

Mon, May 24

rsanthir.quic abandoned D101964: Added support for -Wstack-usage flag and Framesize reporting fix.

Moving forward with simpler approach here:
https://reviews.llvm.org/D102782

Mon, May 24, 9:44 AM · Restricted Project, Restricted Project
rsanthir.quic abandoned D101965: Added Support for Warning Flag -Wstack-usage=.

Moving forward with simpler approach here:
https://reviews.llvm.org/D102782

Mon, May 24, 9:43 AM · Restricted Project, Restricted Project

Fri, May 21

rsanthir.quic added a comment to D102782: Add support for Warning Flag "-Wstack-usage=".

Thanks for reviewing @bruno doesn't look like the failure is related to my change:
https://buildkite.com/llvm-project/premerge-checks/builds/39905#5f70c261-ae54-451b-b771-7012bcee7387
"No space left on device"

Fri, May 21, 10:14 AM · Restricted Project

Wed, May 19

rsanthir.quic updated the diff for D102782: Add support for Warning Flag "-Wstack-usage=".

Localized changes to Options.td, needed to explicitly add negative
flag for -Wframe-larger-than

Wed, May 19, 3:10 PM · Restricted Project
rsanthir.quic added reviewers for D102782: Add support for Warning Flag "-Wstack-usage=": apazos, efriedma, lebedev.ri, jansvoboda11, xbolva00, MaskRay, seaneveson, bruno, MatzeB, hfinkel, craig.topper, dblaikie.
Wed, May 19, 9:04 AM · Restricted Project
rsanthir.quic requested review of D102782: Add support for Warning Flag "-Wstack-usage=".
Wed, May 19, 9:03 AM · Restricted Project

May 5 2021

rsanthir.quic added reviewers for D101965: Added Support for Warning Flag -Wstack-usage=: apazos, efriedma, lebedev.ri, jansvoboda11, xbolva00, MaskRay, seaneveson, bruno, MatzeB, hfinkel, craig.topper.
May 5 2021, 6:16 PM · Restricted Project, Restricted Project
rsanthir.quic added reviewers for D101964: Added support for -Wstack-usage flag and Framesize reporting fix: apazos, efriedma, lebedev.ri, jansvoboda11, xbolva00, MaskRay, seaneveson, bruno, MatzeB, hfinkel, craig.topper.
May 5 2021, 6:14 PM · Restricted Project, Restricted Project
rsanthir.quic added a comment to D101965: Added Support for Warning Flag -Wstack-usage=.

Another approach is explored here:
https://reviews.llvm.org/D101964

May 5 2021, 6:10 PM · Restricted Project, Restricted Project
rsanthir.quic added a comment to D101964: Added support for -Wstack-usage flag and Framesize reporting fix.

Another approach is explored here:
https://reviews.llvm.org/D101965

May 5 2021, 6:10 PM · Restricted Project, Restricted Project
rsanthir.quic requested review of D101965: Added Support for Warning Flag -Wstack-usage=.
May 5 2021, 6:07 PM · Restricted Project, Restricted Project
rsanthir.quic requested review of D101964: Added support for -Wstack-usage flag and Framesize reporting fix.
May 5 2021, 6:05 PM · Restricted Project, Restricted Project

Apr 28 2021

rsanthir.quic committed rG0395f9e70b8f: [ARM] Neon Polynomial vadd Intrinsic fix (authored by rsanthir.quic).
[ARM] Neon Polynomial vadd Intrinsic fix
Apr 28 2021, 12:01 PM
rsanthir.quic closed D100772: [ARM] Neon Polynomial vadd Intrinsic fix.
Apr 28 2021, 12:01 PM · Restricted Project

Apr 26 2021

rsanthir.quic updated the diff for D100772: [ARM] Neon Polynomial vadd Intrinsic fix.

minor fixes and merged https://reviews.llvm.org/D100499

Apr 26 2021, 9:45 AM · Restricted Project
rsanthir.quic added inline comments to D100772: [ARM] Neon Polynomial vadd Intrinsic fix.
Apr 26 2021, 9:41 AM · Restricted Project
rsanthir.quic abandoned D100499: [AArch64] Neon Polynomial vadd Intrinsic Fix.

Merging with https://reviews.llvm.org/D100772

Apr 26 2021, 9:40 AM · Restricted Project

Apr 19 2021

rsanthir.quic added a comment to D100499: [AArch64] Neon Polynomial vadd Intrinsic Fix.

Here's the fix for enabling these on ARM:
https://reviews.llvm.org/D100772

Apr 19 2021, 9:13 AM · Restricted Project
rsanthir.quic requested review of D100772: [ARM] Neon Polynomial vadd Intrinsic fix.
Apr 19 2021, 9:12 AM · Restricted Project
rsanthir.quic updated the summary of D100499: [AArch64] Neon Polynomial vadd Intrinsic Fix.
Apr 19 2021, 9:02 AM · Restricted Project
rsanthir.quic updated the diff for D100499: [AArch64] Neon Polynomial vadd Intrinsic Fix.

only the pol128 intrinsic is incompatible with ARM, the rest should be supported.

Apr 19 2021, 9:02 AM · Restricted Project
rsanthir.quic added a comment to D100499: [AArch64] Neon Polynomial vadd Intrinsic Fix.

Thanks for looking into this @DavidSpickett ! What you found makes sense. I'll update this patch to remove only the poly128 vadd from the mapping. I'll also add another patch that will correctly enable the remaining vadd intrinsics for ARM.

Apr 19 2021, 8:59 AM · Restricted Project

Apr 15 2021

rsanthir.quic added a comment to D100499: [AArch64] Neon Polynomial vadd Intrinsic Fix.

As you mentioned, I thought it was only supported due to CheckFPAdvSIMDEnabled64. If the header is also guarding for AArch64 does that not support the idea that it is AArch64 specific?

Apr 15 2021, 4:08 PM · Restricted Project

Apr 14 2021

rsanthir.quic added inline comments to D99079: [ARM][AArch64] Require appropriate features for crypto algorithms.
Apr 14 2021, 11:58 AM · Restricted Project, Restricted Project
rsanthir.quic requested review of D100499: [AArch64] Neon Polynomial vadd Intrinsic Fix.
Apr 14 2021, 11:45 AM · Restricted Project

Feb 19 2021

rsanthir.quic added a comment to D96381: [AArch64] Adding SHA3 Intrinsics support.

Thank you for reviewing this @DavidSpickett ! If you get a chance could you commit this for me? I do not have commit access yet.

Feb 19 2021, 11:22 AM · Restricted Project, Restricted Project
rsanthir.quic updated the diff for D96825: [AArch64] Adding Neon Polynomial vadd Intrinsics.

rebased on main

Feb 19 2021, 10:48 AM · Restricted Project
rsanthir.quic updated the diff for D96825: [AArch64] Adding Neon Polynomial vadd Intrinsics.

Windows builds were failing due to missing builtins in Intrinsics map

Feb 19 2021, 10:13 AM · Restricted Project
rsanthir.quic reopened D96825: [AArch64] Adding Neon Polynomial vadd Intrinsics.
Feb 19 2021, 10:07 AM · Restricted Project

Feb 18 2021

rsanthir.quic added inline comments to D96381: [AArch64] Adding SHA3 Intrinsics support.
Feb 18 2021, 11:32 AM · Restricted Project, Restricted Project
rsanthir.quic updated the diff for D96381: [AArch64] Adding SHA3 Intrinsics support.

Minor corrections and removed unused code, also added complete testing

Feb 18 2021, 11:29 AM · Restricted Project, Restricted Project

Feb 17 2021

rsanthir.quic updated the diff for D96381: [AArch64] Adding SHA3 Intrinsics support.

Removed extra whitespace

Feb 17 2021, 10:34 AM · Restricted Project, Restricted Project
rsanthir.quic updated the diff for D96825: [AArch64] Adding Neon Polynomial vadd Intrinsics.

removed unnecessary flag in test and changed commit message.

Feb 17 2021, 9:26 AM · Restricted Project
rsanthir.quic added inline comments to D96825: [AArch64] Adding Neon Polynomial vadd Intrinsics.
Feb 17 2021, 9:23 AM · Restricted Project
rsanthir.quic added a reviewer for D96381: [AArch64] Adding SHA3 Intrinsics support: DavidSpickett.
Feb 17 2021, 9:15 AM · Restricted Project, Restricted Project

Feb 16 2021

rsanthir.quic updated the diff for D96825: [AArch64] Adding Neon Polynomial vadd Intrinsics.

rebased due to merge issues

Feb 16 2021, 6:25 PM · Restricted Project
rsanthir.quic added a comment to D96825: [AArch64] Adding Neon Polynomial vadd Intrinsics.

This is the final of three patches to address the following:
https://bugs.llvm.org/show_bug.cgi?id=47828

Feb 16 2021, 5:44 PM · Restricted Project
rsanthir.quic requested review of D96825: [AArch64] Adding Neon Polynomial vadd Intrinsics.
Feb 16 2021, 5:43 PM · Restricted Project

Feb 12 2021

rsanthir.quic added a reviewer for D96381: [AArch64] Adding SHA3 Intrinsics support: kevin.qin.
Feb 12 2021, 10:25 AM · Restricted Project, Restricted Project

Feb 10 2021

rsanthir.quic updated the diff for D96381: [AArch64] Adding SHA3 Intrinsics support.

alphabetized check in NeonEmitter

Feb 10 2021, 9:46 AM · Restricted Project, Restricted Project
rsanthir.quic added a comment to D95655: [AArch64] Adding Neon Sm3 & Sm4 Intrinsics.

@labrinea could you commit this when you have some time please?

Feb 10 2021, 9:24 AM · Restricted Project, Restricted Project

Feb 9 2021

rsanthir.quic added a comment to D96381: [AArch64] Adding SHA3 Intrinsics support.

This is the second of three patches to address the following:
https://bugs.llvm.org/show_bug.cgi?id=47828

Feb 9 2021, 4:50 PM · Restricted Project, Restricted Project
rsanthir.quic requested review of D96381: [AArch64] Adding SHA3 Intrinsics support.
Feb 9 2021, 4:23 PM · Restricted Project, Restricted Project
rsanthir.quic updated the diff for D95655: [AArch64] Adding Neon Sm3 & Sm4 Intrinsics.

Updated test name and checks performed

Feb 9 2021, 12:21 PM · Restricted Project, Restricted Project

Feb 2 2021

rsanthir.quic added a comment to D95655: [AArch64] Adding Neon Sm3 & Sm4 Intrinsics.

@t.p.northover Could you take a look before I ask for this to be merged?

Feb 2 2021, 11:44 AM · Restricted Project, Restricted Project

Jan 29 2021

rsanthir.quic updated the diff for D95655: [AArch64] Adding Neon Sm3 & Sm4 Intrinsics.

Corrected register ordering for sm4e and removed redundant argument in sm3ss1 test

Jan 29 2021, 1:20 PM · Restricted Project, Restricted Project
rsanthir.quic added a comment to D95655: [AArch64] Adding Neon Sm3 & Sm4 Intrinsics.

Thank you for taking a look at this @labrinea !

Jan 29 2021, 1:14 PM · Restricted Project, Restricted Project

Jan 28 2021

rsanthir.quic added a comment to D95655: [AArch64] Adding Neon Sm3 & Sm4 Intrinsics.

This is the first in a series of patches that will address the following:
https://bugs.llvm.org/show_bug.cgi?id=47828

Jan 28 2021, 7:01 PM · Restricted Project, Restricted Project
rsanthir.quic requested review of D95655: [AArch64] Adding Neon Sm3 & Sm4 Intrinsics.
Jan 28 2021, 6:27 PM · Restricted Project, Restricted Project

Dec 14 2020

rsanthir.quic added a comment to D89896: Add loop distribution to the LTO pipeline.

I am trying to enable LoopDistribute, to observe the 43% uplift on hmmer2006, however "flto -mllvm -enable-loop-distribute" does not seem to improve performance. Could you share what other flags you used?

Dec 14 2020, 10:03 AM · Restricted Project

Nov 12 2020

rsanthir.quic abandoned D91393: WIP: Test case that exposes an SLP vectorization missed opportunity.

Incomplete patch, accidentally pushed

Nov 12 2020, 4:19 PM · Restricted Project
rsanthir.quic updated the summary of D91393: WIP: Test case that exposes an SLP vectorization missed opportunity.
Nov 12 2020, 4:10 PM · Restricted Project
rsanthir.quic requested review of D91393: WIP: Test case that exposes an SLP vectorization missed opportunity.
Nov 12 2020, 4:09 PM · Restricted Project

Oct 23 2020

rsanthir.quic added a comment to D89497: [LegalizeTypes] Legalize vector rotate operations.

Yes! If you could commit it for me that would be great! Thanks

Oct 23 2020, 10:53 AM · Restricted Project

Oct 19 2020

rsanthir.quic updated the diff for D89497: [LegalizeTypes] Legalize vector rotate operations.

Ran update_llc_test_checks.py and added missing isVector check

Oct 19 2020, 11:20 AM · Restricted Project

Oct 16 2020

rsanthir.quic added inline comments to D89497: [LegalizeTypes] Legalize vector rotate operations.
Oct 16 2020, 7:24 PM · Restricted Project
rsanthir.quic updated the diff for D89497: [LegalizeTypes] Legalize vector rotate operations.

Added comment for readability

Oct 16 2020, 7:23 PM · Restricted Project
rsanthir.quic updated the diff for D89497: [LegalizeTypes] Legalize vector rotate operations.

updated usage of param

Oct 16 2020, 10:57 AM · Restricted Project
rsanthir.quic updated the diff for D89497: [LegalizeTypes] Legalize vector rotate operations.

Changed the name or the param and added appropriate formatting

Oct 16 2020, 10:54 AM · Restricted Project

Oct 15 2020

rsanthir.quic requested review of D89497: [LegalizeTypes] Legalize vector rotate operations.
Oct 15 2020, 2:26 PM · Restricted Project

Jul 2 2020

rsanthir.quic added a comment to D82342: Preserve GlobalsAA analysis result in LowerConstantIntrinsics .

My apologies @Florian! Thank you @fhahn!

Jul 2 2020, 9:01 PM · Restricted Project

Jul 1 2020

rsanthir.quic updated subscribers of D82342: Preserve GlobalsAA analysis result in LowerConstantIntrinsics .

@Florian since we've given it a couple days, would it be ok to make the commit now?

Jul 1 2020, 12:59 PM · Restricted Project

Jun 23 2020

rsanthir.quic added a comment to D82343: Preserve GlobalsAA analysis result in InjectTLIMappings.

@fhahn yes if you could please commit this for me, it would be much appreciated. I am new to LLVM so I do not have commit rights yet! Could you also do the same for the other patch that was split, D82342

Jun 23 2020, 1:59 PM · Restricted Project
rsanthir.quic abandoned D82063: Preserve GlobalsAA analysis result in LowerConstantIntrinsics and InjectTLIMappings.

Abandoning as I have split in the following:
https://reviews.llvm.org/D82342
https://reviews.llvm.org/D82343

Jun 23 2020, 1:26 PM · Restricted Project

Jun 22 2020

rsanthir.quic created D82343: Preserve GlobalsAA analysis result in InjectTLIMappings.
Jun 22 2020, 7:52 PM · Restricted Project
rsanthir.quic added a comment to D82063: Preserve GlobalsAA analysis result in LowerConstantIntrinsics and InjectTLIMappings.

I've split the changes up:
https://reviews.llvm.org/D82342
https://reviews.llvm.org/D82343

Jun 22 2020, 7:52 PM · Restricted Project
rsanthir.quic created D82342: Preserve GlobalsAA analysis result in LowerConstantIntrinsics .
Jun 22 2020, 7:20 PM · Restricted Project
rsanthir.quic added a comment to D82063: Preserve GlobalsAA analysis result in LowerConstantIntrinsics and InjectTLIMappings.

I can definitely split this into two different patches

Jun 22 2020, 1:26 PM · Restricted Project

Jun 17 2020

rsanthir.quic updated the diff for D82063: Preserve GlobalsAA analysis result in LowerConstantIntrinsics and InjectTLIMappings.

Ran clang-format to update the patch

Jun 17 2020, 5:17 PM · Restricted Project
rsanthir.quic created D82063: Preserve GlobalsAA analysis result in LowerConstantIntrinsics and InjectTLIMappings.
Jun 17 2020, 5:17 PM · Restricted Project