Page MenuHomePhabricator

[Triple] support macOS 11 os version number
ClosedPublic

Authored by arphaman on Jun 22 2020, 4:41 PM.

Details

Summary

macOS goes to 11! This patch adds support for the new version number by ensuring
that existing version comparison routines, and the 'darwin' OS identifier
understands the new numbering scheme. It also adds a new utility method
'getCanonicalVersionForOS', which lets users translate some uses of
macOS 10.16 into macOS 11. This utility method will be used in upcoming
clang and swift patches.

Diff Detail

Event Timeline

arphaman created this revision.Jun 22 2020, 4:41 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 22 2020, 4:41 PM
This revision is now accepted and ready to land.Jun 22 2020, 4:52 PM
arphaman marked an inline comment as done.Jun 22 2020, 5:20 PM
arphaman added inline comments.
llvm/unittests/ADT/TripleTest.cpp
1264

I will remove this triple as this use-case is not relevant and the check below is failing.

steven_wu accepted this revision.Jun 22 2020, 5:37 PM
mstorsjo added inline comments.
llvm/unittests/ADT/TripleTest.cpp
1264

When reading the changes to getMacOSXVersion above I was curious about this case as well - as the code there implies the following one would be 12.0, not 11.1 - but I presume it's too soon to say what that will be? So in that case, removing the test case for now sounds sensible.

arphaman marked an inline comment as done.Jun 22 2020, 11:01 PM
arphaman added inline comments.
llvm/unittests/ADT/TripleTest.cpp
1264

Correct.

This revision was automatically updated to reflect the committed changes.