This is an archive of the discontinued LLVM Phabricator instance.

[MCParser] Support quoted section name for COFF
ClosedPublic

Authored by MaskRay on Jun 19 2020, 2:30 PM.

Details

Summary

This features matches ELFAsmParser and makes it possible to use .section ".llvm.call-graph-profile","n"

Diff Detail

Event Timeline

MaskRay created this revision.Jun 19 2020, 2:30 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 19 2020, 2:30 PM
MaskRay edited the summary of this revision. (Show Details)Jun 19 2020, 2:33 PM
zequanwu accepted this revision.Jun 19 2020, 3:16 PM

LGTM.

This revision is now accepted and ready to land.Jun 19 2020, 3:16 PM
jhenderson added inline comments.Jun 22 2020, 12:40 AM
llvm/test/MC/COFF/section.s
194

Maybe worth using some other characters in the name too, that wouldn't otherwise be allowed, e.g. '@', '{' etc. There's no real need for this to be a "standard" section name after all.

MaskRay updated this revision to Diff 272462.Jun 22 2020, 9:04 AM
MaskRay marked an inline comment as done.

Improve test

This revision was automatically updated to reflect the committed changes.