This is an archive of the discontinued LLVM Phabricator instance.

[builtins][Android] Define HAS_80_BIT_LONG_DOUBLE to 0
ClosedPublic

Authored by rprichard on Jun 19 2020, 12:00 AM.

Details

Summary

Android 32-bit x86 uses a 64-bit long double.

Android 64-bit x86 uses a 128-bit quad-precision long double.

Diff Detail

Event Timeline

rprichard created this revision.Jun 19 2020, 12:00 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 19 2020, 12:00 AM
Herald added subscribers: Restricted Project, krytarowski. · View Herald Transcript
compnerd accepted this revision.Jun 30 2020, 8:41 AM
compnerd added inline comments.
compiler-rt/lib/builtins/int_types.h
149

Personal taste thing:

#if (defined(__i386__) || defined(__x86_64__)) && !(defined(_MSC_VER) || defined(__ANDROID__))

seems a bit easier to parse for me, especially since it sets HAS_80_BIT_LONG_DOUBLE to 1 which makes this then read as:

"x86 or x86_64 and NOT(MSVC OR ANDROID) has fp80"

This revision is now accepted and ready to land.Jun 30 2020, 8:41 AM
rprichard updated this revision to Diff 274917.Jul 1 2020, 2:32 PM

Refactor #if condition.

This revision was automatically updated to reflect the committed changes.