Page MenuHomePhabricator

[mlir][spirv] Legalize subviewop when used with vector transfer
ClosedPublic

Authored by ThomasRaoux on Thu, Jun 18, 9:37 AM.

Details

Summary

Subview operations are not natively supported downstream in the spirv path. This change allows removing subview when used by vector transfer the same way we already do it when they are used by LoadOp/StoreOp

Diff Detail

Event Timeline

ThomasRaoux created this revision.Thu, Jun 18, 9:37 AM
Herald added a project: Restricted Project. · View Herald TranscriptThu, Jun 18, 9:37 AM
rriddle added inline comments.Thu, Jun 18, 10:12 AM
mlir/lib/Conversion/StandardToSPIRV/LegalizeStandardForSPIRV.cpp
35

Same here.

50

Use ArrayRef<Value> instead.

This revision is now accepted and ready to land.Thu, Jun 18, 10:16 AM
ThomasRaoux marked 2 inline comments as done.
This revision was automatically updated to reflect the committed changes.