Page MenuHomePhabricator

[MLIR][Shape] Lower `shape.shape_of` to standard dialect
ClosedPublic

Authored by frgossen on Thu, Jun 18, 7:50 AM.

Details

Summary

Lower shape.shape_of to standard dialect.
This lowering supports statically and dynamically shaped tensors.
Support for unranked tensors will be added soon.

Diff Detail

Event Timeline

frgossen created this revision.Thu, Jun 18, 7:50 AM
Herald added a project: Restricted Project. · View Herald TranscriptThu, Jun 18, 7:50 AM
rriddle added inline comments.Thu, Jun 18, 10:02 AM
mlir/lib/Conversion/ShapeToStandard/ShapeToStandard.cpp
55

nit: Remove this newline.

herhut accepted this revision.Fri, Jun 19, 2:05 AM
herhut added inline comments.
mlir/lib/Conversion/ShapeToStandard/ShapeToStandard.cpp
76

The lowering for unranked tensors will need a look, so it will be target scf. How about splitting this pattern in two and make this one fail early for unranked?

This revision is now accepted and ready to land.Fri, Jun 19, 2:05 AM
frgossen updated this revision to Diff 272078.Fri, Jun 19, 7:59 AM
frgossen marked 2 inline comments as done.

Address comments

This revision was automatically updated to reflect the committed changes.