[MLIR] Move SymbolOpInterface::isPublic() and friends to SymbolOpInterface Trait.

[jurahul]

Summary

• This will allow calling these functions from Op's that support this interface (like FuncOp) directly:

FuncOp func = ...
if (func.isPrivate())

[rriddle]

mlir/include/mlir/IR/SymbolInterfaces.td

61

Add punctuation to the end of each of these.

[jurahul]

Add period at end of comments.

mlir/include/mlir/IR/SymbolInterfaces.td

InterfaceMethod<"Gets the visibility of this symbol.",
       }]
     >,
     InterfaceMethod<"Sets the visibility of this symbol.",
       "void", "setVisibility", (ins "mlir::SymbolTable::Visibility":$vis), [{}],
       /*defaultImplementation=*/[{
         mlir::SymbolTable::setSymbolVisibility(this->getOperation(), vis);
       }]
     >,
+    InterfaceMethod<"Returns true if this symbol has nested visibility.",
+      "bool", "isNested", (ins),  [{}],
+      /*defaultImplementation=*/[{
+        return getVisibility() == mlir::SymbolTable::Visibility::Nested;
+      }]
+    >,
+    InterfaceMethod<"Returns true if this symbol has private visibility.",
+      "bool", "isPrivate", (ins),  [{}],
+      /*defaultImplementation=*/[{
+        return getVisibility() == mlir::SymbolTable::Visibility::Private;
+      }]
+    >,
+    InterfaceMethod<"Returns true if this symbol has public visibility.",
+      "bool", "isPublic", (ins),  [{}],
+      /*defaultImplementation=*/[{
+        return getVisibility() == mlir::SymbolTable::Visibility::Public;
+      }]
+    >,
     InterfaceMethod<[{
         Get all of the uses of the current symbol that are nested within the
         given operation 'from'.
         Note: See mlir::SymbolTable::getSymbolUses for more details.
       }],
       "Optional<::mlir::SymbolTable::UseRange>", "getSymbolUses",
       (ins "Operation *":$from), [{}],
       /*defaultImplementation=*/[{
let verify = [{
     if (concreteOp.isOptionalSymbol()) {
       if(!concreteOp.getAttr(::mlir::SymbolTable::getSymbolAttrName()))
         return success();
     }
     return ::mlir::detail::verifySymbol($_op);
   }];
 
   let extraClassDeclaration = [{
-    using Visibility = mlir::SymbolTable::Visibility;
-
     /// Custom classof that handles the case where the symbol is optional.
     static bool classof(Operation *op) {
       return Base::classof(op)
         && op->getAttr(::mlir::SymbolTable::getSymbolAttrName());
     }
-
-    /// Returns true if this symbol has nested visibility.
-    bool isNested() { return getVisibility() == Visibility::Nested; }
-    /// Returns true if this symbol has private visibility.
-    bool isPrivate() { return getVisibility() == Visibility::Private; }
-    /// Returns true if this symbol has public visibility.
-    bool isPublic() { return getVisibility() == Visibility::Public; }
   }];
 
   let extraTraitClassDeclaration = [{
     using Visibility = mlir::SymbolTable::Visibility;
   }];
 }
 
 //===----------------------------------------------------------------------===//
 // Symbol Traits
 //===----------------------------------------------------------------------===//
 
 // Op defines a symbol table.
 def SymbolTable : NativeOpTrait<"SymbolTable">;
 
 #endif // MLIR_IR_SYMBOLINTERFACES