Page MenuHomePhabricator
Differential D82060

[MLIR] Move SymbolOpInterface::isPublic() and friends to SymbolOpInterface Trait.
ClosedPublic
Actions

Authored by jurahul on Jun 17 2020, 3:46 PM.

Details

Reviewers
rriddle
Commits
rG3d316eb06d91: [MLIR] Move SymbolOpInterface::isPublic() and friends to SymbolOpInterface…
Summary
  • This will allow calling these functions from Op's that support this interface (like FuncOp) directly:
FuncOp func = ...
if (func.isPrivate())

Diff Detail

Event Timeline

jurahul created this revision.Jun 17 2020, 3:46 PM
Herald added a reviewer: rriddle. · View Herald TranscriptJun 17 2020, 3:46 PM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: msifontes, Kayjukh, frgossen and 14 others. · View Herald Transcript
jurahul edited the summary of this revision. (Show Details)Jun 17 2020, 3:47 PM
jurahul edited the summary of this revision. (Show Details)
rriddle accepted this revision.Jun 17 2020, 3:49 PM
rriddle added inline comments.
mlir/include/mlir/IR/SymbolInterfaces.td
61

Add punctuation to the end of each of these.

This revision is now accepted and ready to land.Jun 17 2020, 3:49 PM
jurahul updated this revision to Diff 271511.Jun 17 2020, 3:52 PM

Add period at end of comments.

jurahul marked an inline comment as done.Jun 17 2020, 3:52 PM
Harbormaster completed remote builds in B60728: Diff 271511.Jun 17 2020, 5:17 PM
Harbormaster completed remote builds in B60727: Diff 271510.
Closed by commit rG3d316eb06d91: [MLIR] Move SymbolOpInterface::isPublic() and friends to SymbolOpInterface… (authored by jurahul). · Explain WhyJun 17 2020, 9:35 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
mlir/
include/
mlir/
IR/
27 lines

Diff 271511

View Options

mlir/include/mlir/IR/SymbolInterfaces.td

Loading...