Page MenuHomePhabricator

[mlir] [VectorOps] remove print_i1 from runtime support library
ClosedPublic

Authored by aartbik on Jun 17 2020, 1:06 PM.

Details

Summary

The "i1" (viz. bool) type does not have a proper equivalent on the "C"
size. So, to avoid any ABIs issues, we simply use print_i32 on an i32
value of one or zero for true and false. This has the added advantage
that one less function needs to be implemented when porting the runtime
support library.

Diff Detail

Event Timeline

aartbik created this revision.Jun 17 2020, 1:06 PM
Herald added a project: Restricted Project. · View Herald Transcript
ftynse accepted this revision.Jun 17 2020, 2:31 PM
This revision is now accepted and ready to land.Jun 17 2020, 2:31 PM
This revision was automatically updated to reflect the committed changes.