Page MenuHomePhabricator

Revert "[analyzer][NFC] Don't allow dependency checkers to emit diagnostics"
ClosedPublic

Authored by saugustine on Jun 12 2020, 11:27 AM.

Details

Summary

This reverts commit 33fb9cbe211d1b43d4b84edf34e11001f04cddf0.

That commit violates layering by adding a dependency from StaticAnalyzer/Core
back to StaticAnalyzer/FrontEnd, creating a circular dependency.

I can't see a clean way to fix it except refactoring.

Diff Detail

Event Timeline

saugustine created this revision.Jun 12 2020, 11:27 AM
echristo accepted this revision.Jun 12 2020, 11:32 AM
This revision is now accepted and ready to land.Jun 12 2020, 11:32 AM
Szelethus accepted this revision.Jun 12 2020, 11:34 AM

Yup, I agree. Detailed my answer here a bit: D78126#inline-751477. Thanks for taking initiative!

This revision was automatically updated to reflect the committed changes.