This is an archive of the discontinued LLVM Phabricator instance.

[clangd] Set CWD in semaCodeComplete
ClosedPublic

Authored by kadircet on Jun 11 2020, 1:56 PM.

Diff Detail

Event Timeline

kadircet created this revision.Jun 11 2020, 1:56 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 11 2020, 1:56 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jun 11 2020, 2:54 PM
This revision was automatically updated to reflect the committed changes.

A slightly tangential thing - we recently got an internal bugreport about clangd handling combination of working directory and relative paths for -fmodules-cache-path combination in compile_command.json incorrectly.
I tried some quick hacks but failed - it seems that ultimately the limiting factor is the code in clang dealing with modules not using VFS. It's on our list of things to fix although we don't have a timeframe for it.