Page MenuHomePhabricator
Differential D81663

[mlir][rocdl] Fixing breakage of dim operator from 904f91db
ClosedPublic
Actions

Authored by jerryyin on Jun 11 2020, 8:12 AM.

Details

Reviewers
whchung
frgossen
ftynse
Commits
rGeedd8fe62e38: [mlir][rocdl] Fixing breakage of dim operator from 904f91db
Summary
  • Update the unit test dimOp index to be an operand
  • Refactored the constant naming

Diff Detail

Event Timeline

jerryyin created this revision.Jun 11 2020, 8:12 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 11 2020, 8:12 AM
Herald added subscribers: msifontes, jurahul, Kayjukh and 15 others. · View Herald Transcript
jerryyin added a reviewer: whchung.Jun 11 2020, 8:13 AM

Looks like this commit forget to update rocm unit tests.

jerryyin updated this revision to Diff 270147.Jun 11 2020, 8:17 AM

Update CL header to include [mlir][rocdl]

jerryyin retitled this revision from Fixing breakage of dim operator from 904f91db to [mlir][rocdl] Fixing breakage of dim operator from 904f91db.Jun 11 2020, 8:18 AM
jerryyin added a reviewer: frgossen.
Harbormaster completed remote builds in B59977: Diff 270145.Jun 11 2020, 8:47 AM
ftynse accepted this revision.Jun 11 2020, 9:02 AM
This revision is now accepted and ready to land.Jun 11 2020, 9:02 AM
Harbormaster completed remote builds in B59978: Diff 270147.Jun 11 2020, 9:20 AM
whchung accepted this revision.Jun 11 2020, 9:30 AM
jerryyin closed this revision.Jun 11 2020, 10:37 AM

Landed in eedd8fe62e3896251d5fc60009af5659d990aaf9

Revision Contents
Changeset List

PathSize
mlir/
test/
mlir-rocm-runner/
9 lines
13 lines
9 lines

Diff 270147

View Options

mlir/test/mlir-rocm-runner/gpu-to-hsaco.mlir

Loading...
View Options

mlir/test/mlir-rocm-runner/two-modules.mlir

Loading...
View Options

mlir/test/mlir-rocm-runner/vecadd.mlir

Loading...