Page MenuHomePhabricator

jerryyin (Zhuoran Yin)
User

Projects

User does not belong to any projects.

User Details

User Since
May 19 2020, 12:32 PM (22 w, 4 d)

Recent Activity

Sep 21 2020

jerryyin committed rGf87ceb63eb01: [AMDGPU] Adding mutex to guard lld::elf::link interface use (authored by jerryyin).
[AMDGPU] Adding mutex to guard lld::elf::link interface use
Sep 21 2020, 11:46 AM
jerryyin closed D88038: [AMDGPU] Adding mutex to guard lld::elf::link interface use.
Sep 21 2020, 11:46 AM · Restricted Project
jerryyin updated the summary of D88038: [AMDGPU] Adding mutex to guard lld::elf::link interface use.
Sep 21 2020, 11:40 AM · Restricted Project
jerryyin added a reviewer for D88038: [AMDGPU] Adding mutex to guard lld::elf::link interface use: whchung.
Sep 21 2020, 11:39 AM · Restricted Project
jerryyin requested review of D88038: [AMDGPU] Adding mutex to guard lld::elf::link interface use.
Sep 21 2020, 11:37 AM · Restricted Project

Sep 17 2020

jerryyin closed D87770: [AMDGPU] Fix ROCm unit test memref initialization.

Close as submmited fb182028361504569ff6322bfa12b12e1ab74e30

Sep 17 2020, 9:54 AM · Restricted Project
jerryyin committed rGfb1820283615: [AMDGPU] Fix ROCm unit test memref initialization (authored by jerryyin).
[AMDGPU] Fix ROCm unit test memref initialization
Sep 17 2020, 9:50 AM
jerryyin updated the diff for D87770: [AMDGPU] Fix ROCm unit test memref initialization.

Remove accidental change to clang-format

Sep 17 2020, 8:49 AM · Restricted Project
jerryyin updated the diff for D87770: [AMDGPU] Fix ROCm unit test memref initialization.
Sep 17 2020, 7:40 AM · Restricted Project
jerryyin updated the diff for D87770: [AMDGPU] Fix ROCm unit test memref initialization.

Added createLowerToCFGPass for scf.for lowering

Sep 17 2020, 7:37 AM · Restricted Project
jerryyin committed rGe4a198eeee3c: [AMDGPU] Bump to ROCm 3.7 dependency hip_hcc->amdhip64 (authored by jerryyin).
[AMDGPU] Bump to ROCm 3.7 dependency hip_hcc->amdhip64
Sep 17 2020, 6:48 AM
jerryyin closed D87773: [AMDGPU] Bump to ROCm 3.7 dependency hip_hcc->amdhip64.
Sep 17 2020, 6:48 AM · Restricted Project

Sep 16 2020

jerryyin added a reviewer for D87773: [AMDGPU] Bump to ROCm 3.7 dependency hip_hcc->amdhip64: whchung.
Sep 16 2020, 8:59 AM · Restricted Project
jerryyin requested review of D87773: [AMDGPU] Bump to ROCm 3.7 dependency hip_hcc->amdhip64.
Sep 16 2020, 8:58 AM · Restricted Project
jerryyin retitled D87770: [AMDGPU] Fix ROCm unit test memref initialization from Fix ROCm test memref initialization to [AMDGPU] Fix ROCm unit test memref initialization.
Sep 16 2020, 8:55 AM · Restricted Project
jerryyin added a reviewer for D87770: [AMDGPU] Fix ROCm unit test memref initialization: whchung.
Sep 16 2020, 8:48 AM · Restricted Project
jerryyin requested review of D87770: [AMDGPU] Fix ROCm unit test memref initialization.
Sep 16 2020, 8:46 AM · Restricted Project

Jun 22 2020

jerryyin accepted D82333: [mlir][mlir-rocm-runner] Remove compile-time warning. NFC..

LGTM

Jun 22 2020, 4:07 PM · Restricted Project

Jun 11 2020

jerryyin committed rGeedd8fe62e38: [mlir][rocdl] Fixing breakage of dim operator from 904f91db (authored by jerryyin).
[mlir][rocdl] Fixing breakage of dim operator from 904f91db
Jun 11 2020, 11:01 AM
jerryyin closed D81663: [mlir][rocdl] Fixing breakage of dim operator from 904f91db.

Landed in eedd8fe62e3896251d5fc60009af5659d990aaf9

Jun 11 2020, 11:00 AM · Restricted Project
jerryyin added a reviewer for D81663: [mlir][rocdl] Fixing breakage of dim operator from 904f91db: frgossen.
Jun 11 2020, 8:46 AM · Restricted Project
jerryyin retitled D81663: [mlir][rocdl] Fixing breakage of dim operator from 904f91db from Fixing breakage of dim operator from 904f91db to [mlir][rocdl] Fixing breakage of dim operator from 904f91db.
Jun 11 2020, 8:46 AM · Restricted Project
jerryyin updated the diff for D81663: [mlir][rocdl] Fixing breakage of dim operator from 904f91db.

Update CL header to include [mlir][rocdl]

Jun 11 2020, 8:46 AM · Restricted Project
jerryyin added a comment to D81663: [mlir][rocdl] Fixing breakage of dim operator from 904f91db.

Looks like this commit forget to update rocm unit tests.

Jun 11 2020, 8:46 AM · Restricted Project
jerryyin created D81663: [mlir][rocdl] Fixing breakage of dim operator from 904f91db.
Jun 11 2020, 8:14 AM · Restricted Project
jerryyin added a reviewer for D81663: [mlir][rocdl] Fixing breakage of dim operator from 904f91db: whchung.
Jun 11 2020, 8:14 AM · Restricted Project
jerryyin committed rG2abad3433f9f: [mlir][rocdl] Adding vector to ROCDL dialect lowering (authored by jerryyin).
[mlir][rocdl] Adding vector to ROCDL dialect lowering
Jun 11 2020, 7:42 AM
jerryyin closed D81276: [mlir][rocdl] Adding vector to ROCDL dialect lowering.

Pushed to trunk revision: 2abad3433f9f48cb0a103726a9af1ad79603d23d

Jun 11 2020, 7:41 AM · Restricted Project

Jun 10 2020

jerryyin added a comment to D81276: [mlir][rocdl] Adding vector to ROCDL dialect lowering.

I'm pretty sure the build failure has nothing to do with this CL. I will wait till tomorrow to push it upstream if there's no further feedback to it. Thanks.

Jun 10 2020, 8:44 AM · Restricted Project
jerryyin updated the diff for D81276: [mlir][rocdl] Adding vector to ROCDL dialect lowering.

Resolve review feedbacks

Jun 10 2020, 7:37 AM · Restricted Project
jerryyin added inline comments to D81276: [mlir][rocdl] Adding vector to ROCDL dialect lowering.
Jun 10 2020, 7:37 AM · Restricted Project

Jun 9 2020

jerryyin updated the diff for D81276: [mlir][rocdl] Adding vector to ROCDL dialect lowering.

Rebase and remove blank line at EOF

Jun 9 2020, 8:12 AM · Restricted Project
jerryyin added inline comments to D81276: [mlir][rocdl] Adding vector to ROCDL dialect lowering.
Jun 9 2020, 7:05 AM · Restricted Project
jerryyin updated the diff for D81276: [mlir][rocdl] Adding vector to ROCDL dialect lowering.

Fix clang-tidy warning by removing unecessary local varaible

Jun 9 2020, 7:05 AM · Restricted Project

Jun 8 2020

jerryyin updated the diff for D81276: [mlir][rocdl] Adding vector to ROCDL dialect lowering.

Adjust instruction sequences, remove redundant curly braces

Jun 8 2020, 1:52 PM · Restricted Project
jerryyin updated the diff for D81276: [mlir][rocdl] Adding vector to ROCDL dialect lowering.

Adding addresspace check

Jun 8 2020, 1:18 PM · Restricted Project
jerryyin added a comment to D81276: [mlir][rocdl] Adding vector to ROCDL dialect lowering.

Could you please elaborate on your plans for this revision going forward?
@ThomasRaoux, @mravishankar and I are looking into directly using the vector dialect to target GPUs and this looks like this is going in a similar direction.

Jun 8 2020, 12:08 PM · Restricted Project
jerryyin updated the diff for D81276: [mlir][rocdl] Adding vector to ROCDL dialect lowering.

Address review feedbacks

Jun 8 2020, 9:22 AM · Restricted Project
jerryyin added inline comments to D81276: [mlir][rocdl] Adding vector to ROCDL dialect lowering.
Jun 8 2020, 9:22 AM · Restricted Project

Jun 5 2020

jerryyin added inline comments to D81276: [mlir][rocdl] Adding vector to ROCDL dialect lowering.
Jun 5 2020, 4:16 PM · Restricted Project
jerryyin added inline comments to D81276: [mlir][rocdl] Adding vector to ROCDL dialect lowering.
Jun 5 2020, 3:43 PM · Restricted Project
jerryyin added a reviewer for D81276: [mlir][rocdl] Adding vector to ROCDL dialect lowering: whchung.
Jun 5 2020, 2:02 PM · Restricted Project
jerryyin updated the diff for D81276: [mlir][rocdl] Adding vector to ROCDL dialect lowering.

Fix unit test typo

Jun 5 2020, 1:27 PM · Restricted Project
jerryyin updated the diff for D81276: [mlir][rocdl] Adding vector to ROCDL dialect lowering.

Misc update to align with local branch

Jun 5 2020, 1:27 PM · Restricted Project
jerryyin added inline comments to D81276: [mlir][rocdl] Adding vector to ROCDL dialect lowering.
Jun 5 2020, 12:22 PM · Restricted Project
jerryyin updated the diff for D81276: [mlir][rocdl] Adding vector to ROCDL dialect lowering.

Drop irrelevant file

Jun 5 2020, 10:01 AM · Restricted Project
jerryyin created D81276: [mlir][rocdl] Adding vector to ROCDL dialect lowering.
Jun 5 2020, 10:01 AM · Restricted Project

Jun 3 2020

jerryyin accepted D80676: [mlir][gpu] Introduce mlir-rocm-runner..

LGTM

Jun 3 2020, 2:20 PM · Restricted Project, Restricted Project
jerryyin accepted D80676: [mlir][gpu] Introduce mlir-rocm-runner..

Good job, mostly minor issues, except the one related with the difference between mlir-rocm-runner and mlir-cuda-runner. Giving an accept to unblock future development, but we need to figure out the best way to resolve the differences between runner wrapper interfaces.

Jun 3 2020, 12:38 PM · Restricted Project, Restricted Project

May 28 2020

jerryyin added inline comments to D80676: [mlir][gpu] Introduce mlir-rocm-runner..
May 28 2020, 1:45 PM · Restricted Project, Restricted Project

May 21 2020

jerryyin committed rG9c53ac08de7c: [mlir][rocdl] Exposing buffer load/store intrinsic (authored by jerryyin).
[mlir][rocdl] Exposing buffer load/store intrinsic
May 21 2020, 7:31 AM
jerryyin closed D80233: [mlir][rocdl] Exposing buffer load/store intrinsic.

The CL has landed.

May 21 2020, 7:31 AM · Restricted Project, Restricted Project

May 20 2020

jerryyin added inline comments to D80233: [mlir][rocdl] Exposing buffer load/store intrinsic.
May 20 2020, 8:10 AM · Restricted Project, Restricted Project
jerryyin updated the diff for D80233: [mlir][rocdl] Exposing buffer load/store intrinsic.

Inline printIntrinsic function

May 20 2020, 8:10 AM · Restricted Project, Restricted Project
jerryyin abandoned D80297: Inline the printintrincis function.
May 20 2020, 8:10 AM · Restricted Project
jerryyin created D80297: Inline the printintrincis function.
May 20 2020, 7:35 AM · Restricted Project

May 19 2020

jerryyin updated the diff for D80233: [mlir][rocdl] Exposing buffer load/store intrinsic.

Fix lint error

May 19 2020, 2:53 PM · Restricted Project, Restricted Project
jerryyin added reviewers for D80233: [mlir][rocdl] Exposing buffer load/store intrinsic: whchung, rtaylor.
May 19 2020, 1:43 PM · Restricted Project, Restricted Project
jerryyin created D80233: [mlir][rocdl] Exposing buffer load/store intrinsic.
May 19 2020, 1:43 PM · Restricted Project, Restricted Project