This is an archive of the discontinued LLVM Phabricator instance.

[mlir][Linalg][Doc] Fix of misleading example in Property 2
ClosedPublic

Authored by limo1996 on Jun 11 2020, 12:53 AM.

Details

Summary

Code example in MLIR Linalg doc fixed because it referenced non-existing variables and some parameters were of wrong types.

Diff Detail

Event Timeline

limo1996 created this revision.Jun 11 2020, 12:53 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 11 2020, 12:53 AM

Could you please provide a better commit description, i.e. _why_ this change rather than _what_ the change is? https://mlir.llvm.org/getting_started/Contributing/#commit-messages

limo1996 retitled this revision from [mlir][Linalg][Doc] Property 2: example fixed to [mlir][Linalg][Doc] Fix of misleading example in Property 2.Jun 11 2020, 1:20 AM

Could you please provide a better commit description, i.e. _why_ this change rather than _what_ the change is? https://mlir.llvm.org/getting_started/Contributing/#commit-messages

Changed it!

limo1996 edited the summary of this revision. (Show Details)Jun 11 2020, 1:47 AM
ftynse accepted this revision.Jun 11 2020, 1:49 AM
This revision is now accepted and ready to land.Jun 11 2020, 1:49 AM
This revision was automatically updated to reflect the committed changes.