Page MenuHomePhabricator

[MLIR] Print function name when ReturnOp verification fails
ClosedPublic

Authored by jurahul on Jun 9 2020, 3:22 PM.

Details

Summary
  • Print function name when ReturnOp verification fails
  • This helps easily finding the invalid ReturnOp in an IR dump.

Diff Detail

Event Timeline

jurahul created this revision.Jun 9 2020, 3:22 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 9 2020, 3:22 PM

Can you provide justification in your description as to why this change makes sense?

jurahul edited the summary of this revision. (Show Details)Jun 9 2020, 4:04 PM
jurahul edited the summary of this revision. (Show Details)Jun 9 2020, 4:05 PM
jurahul updated this revision to Diff 269697.Jun 9 2020, 4:21 PM

Fix test

rriddle accepted this revision.Jun 10 2020, 11:09 AM
rriddle added inline comments.
mlir/lib/Dialect/StandardOps/IR/Ops.cpp
2027

nit: Use a @ before the function names.

This revision is now accepted and ready to land.Jun 10 2020, 11:09 AM
jurahul updated this revision to Diff 269936.Jun 10 2020, 12:08 PM

Prefix function names with @

jurahul marked an inline comment as done.Jun 10 2020, 12:10 PM
This revision was automatically updated to reflect the committed changes.