This is an archive of the discontinued LLVM Phabricator instance.

Differential D81293

[libc++][CMake] Add CMake caches for commonly supported configurations
ClosedPublic

Authored by ldionne on Jun 5 2020, 12:14 PM.

Details

Reviewers
EricWF
Group Reviewers
Restricted Project
Commits
rGd9dec697cbb7: [libc++][CMake] Add CMake caches for commonly supported configurations
Summary

This commit adds CMake caches for the various configurations of libc++
that are tested by our build bots.

Diff Detail

Event Timeline

ldionne created this revision.Jun 5 2020, 12:14 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 5 2020, 12:14 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added subscribers: libcxx-commits, dexonsmith, jkorous, mgorny. · View Herald Transcript
ldionne added a reviewer: EricWF.Jun 5 2020, 12:15 PM
ldionne added a child revision: D81294: [libc++] Use the supported caches to setup build bots.
ldionne added a comment.Jun 5 2020, 12:18 PM

The benefit of this approach is that it's easier to reproduce a build bot failure by just using the corresponding cache. Of course, that doesn't account for differences like compiler version or operating system, but it's a step in the right direction.

Harbormaster failed remote builds in B59306: Diff 268908!Jun 5 2020, 1:28 PM
smeenai added a subscriber: smeenai.Jun 8 2020, 5:54 PM

I *really* like this :)

ldionne accepted this revision as: Restricted Project.Jun 9 2020, 11:51 AM
This revision was not accepted when it landed; it landed in state Needs Review.Jun 9 2020, 12:07 PM
Closed by commit rGd9dec697cbb7: [libc++][CMake] Add CMake caches for commonly supported configurations (authored by ldionne). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents

Diff 269630

libcxx/cmake/caches/Generic-32bits.cmake

  • This file was added.
set(LLVM_BUILD_32_BITS ON CACHE BOOL "")

libcxx/cmake/caches/Generic-asan.cmake

  • This file was added.
set(LLVM_USE_SANITIZER "Address" CACHE STRING "")

libcxx/cmake/caches/Generic-cxx03.cmake

  • This file was added.
set(LLVM_LIT_ARGS "--param std=c++03" CACHE STRING "")

libcxx/cmake/caches/Generic-cxx11.cmake

  • This file was added.
set(LLVM_LIT_ARGS "--param std=c++11" CACHE STRING "")

libcxx/cmake/caches/Generic-cxx14.cmake

  • This file was added.
set(LLVM_LIT_ARGS "--param std=c++14" CACHE STRING "")

libcxx/cmake/caches/Generic-cxx17.cmake

  • This file was added.
set(LLVM_LIT_ARGS "--param std=c++17" CACHE STRING "")

libcxx/cmake/caches/Generic-cxx2a.cmake

  • This file was added.
set(LLVM_LIT_ARGS "--param std=c++2a" CACHE STRING "")

libcxx/cmake/caches/Generic-msan.cmake

  • This file was added.
set(LLVM_USE_SANITIZER "MemoryWithOrigins" CACHE STRING "")

libcxx/cmake/caches/Generic-noexceptions.cmake

  • This file was added.
set(LIBCXX_ENABLE_EXCEPTIONS OFF CACHE BOOL "")
set(LIBCXXABI_ENABLE_EXCEPTIONS OFF CACHE BOOL "")

libcxx/cmake/caches/Generic-singlethreaded.cmake

  • This file was added.
set(LIBCXX_ENABLE_THREADS OFF CACHE BOOL "")
set(LIBCXXABI_ENABLE_THREADS OFF CACHE BOOL "")
set(LIBCXX_ENABLE_MONOTONIC_CLOCK OFF CACHE BOOL "")

libcxx/cmake/caches/Generic-tsan.cmake

  • This file was added.
set(LLVM_USE_SANITIZER "Thread" CACHE STRING "")

libcxx/cmake/caches/Generic-ubsan.cmake

  • This file was added.
set(LLVM_USE_SANITIZER "Undefined" CACHE STRING "")
set(LIBCXX_ABI_UNSTABLE ON CACHE BOOL "")

libcxx/cmake/caches/README.md

  • This file was added.
# libc++ / libc++abi configuration caches
This directory contains CMake caches for the supported configurations of libc++.
Some of the configurations are specific to a vendor, others are generic and not
tied to any vendor.
While we won't explicitly work to break configurations not listed here, any
configuration not listed here is not explicitly supported. If you use or ship
libc++ under a configuration not listed here, you should work with the libc++
maintainers to make it into a supported configuration and add it here.
Similarly, adding any new configuration that's not already covered must be
discussed with the libc++ maintainers as it entails a maintenance burden.