[builtins] Move more float128-related helpers to GENERIC_TF_SOURCES list

[atrosinenko]

Summary

There are two different _generic_ lists of source files in the compiler-rt/lib/builtins/CMakeLists.txt. Now there is no simple way to not use the tf-variants of helpers at all.

Since there exists a separate GENERIC_TF_SOURCES list, it seems quite natural to move all float128-related helpers there. If it is not possible for some reason, it would be useful to have an explanation of that reason somewhere near the GENERIC_TF_SOURCES definition.

[atrosinenko]

1. Since different quite unrelated patches failed on Jun 5 with quite the same messages, just rebase onto current master expecting build failure to go away
2. Ping

[atrosinenko]

@samsonov Something strange happens with the compiler-rt tests: when this patch was initially uploaded, the tests were failed with seemingly unrelated failures: B59287. Some tests are broken upstream, I concluded.

Today I have rebased the patch onto current master branch, and the tests passed, as expected: B60775. Right, the tests were actually broken upstream, I concluded.

Then I rebased some other my patch that were failing with similar messages: D81408. There may be some clang-format issues but the thing I not expected were the same test failures I have seen here: B60811. Even more: the B60775 build is marked "Passed", but when I click on "Build 73581 pre-merge checks (buildkite)" and then go to "Exterenl Link: buildkite build" it shows Linux build as failed.

Returning to the original test failures:

linux > cfi-devirt-lld-thinlto-x86_64.cfi-devirt-lld-thinlto-x86_64::anon-namespace.cpp

They contain the following error message:

ld.lld: error: Invalid summary version 8. Version should be in the range [1-7].

This message is seemingly printed by

llvm/lib/Bitcode/Reader/BitcodeReader.cpp

if (Version < 1 || Version > ModuleSummaryIndex::BitcodeSummaryVersion)
  return error("Invalid summary version " + Twine(Version) +
               ". Version should be in the range [1-" +
               Twine(ModuleSummaryIndex::BitcodeSummaryVersion) +
               "].");

with ModuleSummaryIndex::BitcodeSummaryVersion defined to be 8 in current version of repository.

When trying to reproduce this on my local machine, I built LLVM together with clang, compiler-rt and lld. The tests passed. Then I modified the .script file to directly refer to locally built bin/FileCheck, bin/not, etc. and added -v option. Turned out, the Clang driver invokes /path/to/build/directory/bin/ld.lld but after chmod -x bin/lld it silently falls back to /usr/bin/ld.lld. Finally, the build log contains line "-- lld project is disabled" suggesting it does use the system-provided ld.lld that prints this warning.

[atrosinenko]

Ping.

[aykevl]

Look reasonable from my POV, but I don't know enough about CMake or the compiler-rt build system to LGTM this.

[efriedma]

compiler-rt/lib/builtins/CMakeLists.txt

141–142

Missed powitf?

[atrosinenko]

Move missed powitf2.c source as well.

[atrosinenko]

compiler-rt/lib/builtins/CMakeLists.txt

141–142

Fixed, thank you.

[efriedma]

LGTM

compiler-rt/lib/builtins/CMakeLists.txt

 # TODO: Need to add a mechanism for logging errors when builtin source files are
 # added to a sub-directory and not this CMakeLists file.
 set(GENERIC_SOURCES
   absvdi2.c
   absvsi2.c
   absvti2.c
   adddf3.c
   addsf3.c
-  addtf3.c
   addvdi3.c
   addvsi3.c
   addvti3.c
   apple_versioning.c
   ashldi3.c
   ashlti3.c
   ashrdi3.c
   ashrti3.c
set(GENERIC_SOURCES
   divdc3.c
   divdf3.c
   divdi3.c
   divmoddi4.c
   divmodsi4.c
   divsc3.c
   divsf3.c
   divsi3.c
-  divtc3.c
   divti3.c
-  divtf3.c
   extendsfdf2.c
   extendhfsf2.c
   ffsdi2.c
   ffssi2.c
   ffsti2.c
   fixdfdi.c
   fixdfsi.c
   fixdfti.c
set(GENERIC_SOURCES
   muldf3.c
   muldi3.c
   mulodi4.c
   mulosi4.c
   muloti4.c
   mulsc3.c
   mulsf3.c
   multi3.c
-  multf3.c
   mulvdi3.c
   mulvsi3.c
   mulvti3.c
   negdf2.c
   negdi2.c
   negsf2.c
   negti2.c
   negvdi2.c
   negvsi2.c
   negvti2.c
   os_version_check.c
   paritydi2.c
   paritysi2.c
   parityti2.c
   popcountdi2.c
   popcountsi2.c
   popcountti2.c
   powidf2.c
   powisf2.c
-  powitf2.c
   subdf3.c
   subsf3.c
   subvdi3.c
   subvsi3.c
   subvti3.c
-  subtf3.c
   trampoline_setup.c
   truncdfhf2.c
   truncdfsf2.c
   truncsfhf2.c
   ucmpdi2.c
   ucmpti2.c
   udivdi3.c
   udivmoddi4.c
   udivmodsi4.c
   udivmodti4.c
   udivsi3.c
   udivti3.c
   umoddi3.c
   umodsi3.c
   umodti3.c
 )
 
 set(GENERIC_TF_SOURCES
+  addtf3.c
   comparetf2.c
+  divtc3.c
+  divtf3.c
   extenddftf2.c
   extendsftf2.c
   fixtfdi.c
   fixtfsi.c
   fixtfti.c
   fixunstfdi.c
   fixunstfsi.c
   fixunstfti.c
   floatditf.c
   floatsitf.c
   floattitf.c
   floatunditf.c
   floatunsitf.c
   floatuntitf.c
   multc3.c
+  multf3.c
+  powitf2.c
+  subtf3.c
   trunctfdf2.c
   trunctfsf2.c
 )
 
 option(COMPILER_RT_EXCLUDE_ATOMIC_BUILTIN
   "Skip the atomic builtin (these should normally be provided by a shared library)"
   On)