This is an archive of the discontinued LLVM Phabricator instance.

Correctly report modified status for DataFlowSanitizer
ClosedPublic

Authored by serge-sans-paille on Jun 5 2020, 12:56 AM.

Diff Detail

Event Timeline

Herald added a project: Restricted Project. · View Herald TranscriptJun 5 2020, 12:56 AM
vitalybuka added inline comments.
llvm/lib/Transforms/Instrumentation/DataFlowSanitizer.cpp
1048

there is a global inserted in the beginning

vitalybuka added inline comments.
llvm/lib/Transforms/Instrumentation/DataFlowSanitizer.cpp
815

maybe always true after this point?

serge-sans-paille marked 3 inline comments as done.
serge-sans-paille added inline comments.
llvm/lib/Transforms/Instrumentation/DataFlowSanitizer.cpp
815

only if the globals don't already exist.

vitalybuka added inline comments.Jun 10 2020, 3:08 AM
llvm/lib/Transforms/Instrumentation/DataFlowSanitizer.cpp
815

initializeCallbackFunctions and initializeRuntimeFunctions also changes the module
and even without inserting globals it change setThreadLocalMode

serge-sans-paille marked an inline comment as done.

Take review into account.

serge-sans-paille marked an inline comment as done.Jun 11 2020, 12:31 AM
vitalybuka accepted this revision.Jun 11 2020, 3:19 AM
This revision is now accepted and ready to land.Jun 11 2020, 3:19 AM
This revision was automatically updated to reflect the committed changes.