Correctly report modified status for GCOVProfiling

[serge-sans-paille]

Summary

Related to https://reviews.llvm.org/D80916

[calixte]

llvm/lib/Transforms/Instrumentation/GCOVProfiling.cpp

572

My bad...
Anyway there is some extra flush/dump only if there are some fork/exec*.
So if I understand correctly the purpose of the returned boolean, you need to check if a flush/dump has been added or not and check if emitProfileArcs changed something and return a OR on these two values.

[serge-sans-paille]

Take review into account.

llvm/lib/Transforms/Instrumentation/GCOVProfiling.cpp

bool GCOVProfiler::runOnModule(
   Ctx = &M.getContext();
 
   AddFlushBeforeForkAndExec();
 
   FilterRe = createRegexesFromString(Options.Filter);
   ExcludeRe = createRegexesFromString(Options.Exclude);
 
   if (Options.EmitNotes) emitProfileNotes();
-  if (Options.EmitData) return emitProfileArcs();
-  return false;
+  if (Options.EmitData) emitProfileArcs();
+  return true; // Because of the added flush.
 }
 
 PreservedAnalyses GCOVProfilerPass::run(Module &M,
                                         ModuleAnalysisManager &AM) {
 
   GCOVProfiler Profiler(GCOVOpts);
   FunctionAnalysisManager &FAM =
       AM.getResult<FunctionAnalysisManagerModuleProxy>(M).getManager();