Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

Differential D81227

Correctly report modified status for GCOVProfiling
ClosedPublic
Actions

Authored by serge-sans-paille on Jun 5 2020, 12:23 AM.

Details

Reviewers
calixte
jyknight
nikic
foad
jdoerfert
Commits
rGef1a7f2f01db: Update pass status for GCOVProfiling
Summary

Related to https://reviews.llvm.org/D80916

Diff Detail

Event Timeline

serge-sans-paille created this revision.Jun 5 2020, 12:23 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 5 2020, 12:23 AM
Herald added subscribers: llvm-commits, hiraditya. · View Herald Transcript
calixte added inline comments.Jun 5 2020, 1:04 AM
llvm/lib/Transforms/Instrumentation/GCOVProfiling.cpp
564

My bad...
Anyway there is some extra flush/dump only if there are some fork/exec*.
So if I understand correctly the purpose of the returned boolean, you need to check if a flush/dump has been added or not and check if emitProfileArcs changed something and return a OR on these two values.

serge-sans-paille updated this revision to Diff 269223.Jun 8 2020, 7:34 AM

Take review into account.

calixte accepted this revision.Jun 8 2020, 11:56 AM
This revision is now accepted and ready to land.Jun 8 2020, 11:56 AM
Closed by commit rGef1a7f2f01db: Update pass status for GCOVProfiling (authored by serge-sans-paille). · Explain WhyJun 9 2020, 5:27 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
llvm/
lib/
Transforms/
Instrumentation/
13 lines

Diff 269502

View Options

llvm/lib/Transforms/Instrumentation/GCOVProfiling.cpp

Loading...