This is an archive of the discontinued LLVM Phabricator instance.

Correctly report modified status for GCOVProfiling

Authored by serge-sans-paille on Jun 5 2020, 12:23 AM.

Diff Detail

Event Timeline

Herald added a project: Restricted Project. · View Herald TranscriptJun 5 2020, 12:23 AM
calixte added inline comments.Jun 5 2020, 1:04 AM

My bad...
Anyway there is some extra flush/dump only if there are some fork/exec*.
So if I understand correctly the purpose of the returned boolean, you need to check if a flush/dump has been added or not and check if emitProfileArcs changed something and return a OR on these two values.

Take review into account.

calixte accepted this revision.Jun 8 2020, 11:56 AM
This revision is now accepted and ready to land.Jun 8 2020, 11:56 AM
This revision was automatically updated to reflect the committed changes.