This is an archive of the discontinued LLVM Phabricator instance.

Use libClangTesting in the unittest for AST matchers
ClosedPublic

Authored by gribozavr on Jun 4 2020, 5:24 AM.

Details

Summary

The unittest for AST matchers has its own way to specify language
standards. I unified it with the shared infrastructure from
libClangTesting.

Diff Detail

Event Timeline

gribozavr created this revision.Jun 4 2020, 5:24 AM
Herald added a project: Restricted Project. · View Herald Transcript
gribozavr updated this revision to Diff 268440.Jun 4 2020, 5:32 AM

Changed C++20-only tests to C++20-or-later.

hlopko accepted this revision.Jun 4 2020, 6:54 AM

Nice! :)

This revision is now accepted and ready to land.Jun 4 2020, 6:54 AM
This revision was automatically updated to reflect the committed changes.
njames93 added inline comments.
clang/unittests/ASTMatchers/ASTMatchersTest.h
62

Bit late, but surely these should have been const arrays instead of vectors.

gribozavr2 marked an inline comment as done.Jun 4 2020, 11:22 AM
gribozavr2 added a subscriber: gribozavr2.
gribozavr2 added inline comments.
clang/unittests/ASTMatchers/ASTMatchersTest.h
62