This is an archive of the discontinued LLVM Phabricator instance.

Renamed Lang_C to Lang_C99, Lang_CXX to Lang_CXX03, and 2a to 20
ClosedPublic

Authored by gribozavr on Jun 2 2020, 6:27 AM.

Details

Summary

I think we would be better off with tests explicitly specifying the
language mode. Right now Lang_C means C99, but reads as "any C version",
or as "unspecified C version".

I also changed '-std=c++98' to '-std=c++03' because they are aliases (so
there is no difference in practice), because Clang implements C++03
rules in practice, and because 03 makes a nice sortable progression
between 03, 11, 14, 17, 20.

Diff Detail

Unit TestsFailed

Event Timeline

gribozavr created this revision.Jun 2 2020, 6:27 AM
Herald added a project: Restricted Project. · View Herald Transcript
gribozavr updated this revision to Diff 267866.Jun 2 2020, 6:34 AM

Also rename 2a to 20.

gribozavr2 retitled this revision from Renamed Lang_C to Lang_C99 and Lang_CXX to Lang_CXX03 to Renamed Lang_C to Lang_C99, Lang_CXX to Lang_CXX03, and 2a to 20.Jun 2 2020, 6:35 AM
hlopko accepted this revision.Jun 2 2020, 6:42 AM

Looks good, thanks!

This revision is now accepted and ready to land.Jun 2 2020, 6:42 AM
This revision was automatically updated to reflect the committed changes.