Page MenuHomePhabricator

GlobalISel: fix CombinerHelper::matchEqualDefs()
ClosedPublic

Authored by rampitec on May 28 2020, 3:34 PM.

Details

Summary

This matcher was always returning true for the different
results of a same instruction.

Diff Detail

Event Timeline

rampitec created this revision.May 28 2020, 3:34 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 28 2020, 3:34 PM
arsenm added inline comments.May 29 2020, 5:51 AM
llvm/test/CodeGen/AMDGPU/GlobalISel/postlegalizercombiner-select.mir
17

I would prefer to use an explicit G_IMPLICIT_DEF rather than relying on an undef operand. I've been thinking undef operands should be a verifier error for SSA MIR

This revision is now accepted and ready to land.May 29 2020, 6:38 AM
rampitec updated this revision to Diff 267262.May 29 2020, 9:10 AM
rampitec marked an inline comment as done.

Use G_IMPLICIT_DEF in the test.