This is an archive of the discontinued LLVM Phabricator instance.

[GlobalISel][InlineAsm] Add missing EarlyClobber flag to inline asm output operands
ClosedPublic

Authored by kschwarz on May 23 2020, 5:19 AM.

Details

Summary

Previously, we only added early-clobber flags to the 'group' immediate flag operand
of an inline asm operand.
However, we also have to add the EarlyClobber flag to the MachineOperand itself.

This fixes PR46028

Diff Detail

Event Timeline

kschwarz created this revision.May 23 2020, 5:19 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 23 2020, 5:19 AM
arsenm accepted this revision.May 23 2020, 8:33 AM
This revision is now accepted and ready to land.May 23 2020, 8:33 AM
phosek added a subscriber: phosek.May 24 2020, 4:38 PM
leonardchan accepted this revision.May 26 2020, 12:52 PM

LGTM. Confirmed the test passes after this and the correct assembly is generated. Thanks for the fix!

This revision was automatically updated to reflect the committed changes.