Page MenuHomePhabricator

kschwarz (Konstantin Schwarz)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 30 2018, 4:54 AM (150 w, 1 d)

Recent Activity

Yesterday

kschwarz added inline comments to D103815: [ELF] Consider that NOLOAD sections should be placed in a PT_LOAD segment.
Mon, Jun 14, 3:36 AM · Restricted Project

Wed, Jun 9

kschwarz added inline comments to D103815: [ELF] Consider that NOLOAD sections should be placed in a PT_LOAD segment.
Wed, Jun 9, 7:52 AM · Restricted Project
kschwarz updated the diff for D103815: [ELF] Consider that NOLOAD sections should be placed in a PT_LOAD segment.

Remove the check for noload, adapt existing tests

Wed, Jun 9, 6:53 AM · Restricted Project
kschwarz added a comment to D103815: [ELF] Consider that NOLOAD sections should be placed in a PT_LOAD segment.

https://reviews.llvm.org/D45264 specifically introduced the check for sec->noload, stating that this conforms to GNU ld 2.29

Wed, Jun 9, 3:26 AM · Restricted Project

Tue, Jun 8

kschwarz added a comment to D103815: [ELF] Consider that NOLOAD sections should be placed in a PT_LOAD segment.

Thanks for your comments! I've applied the suggested formatting changes.

Tue, Jun 8, 4:10 AM · Restricted Project
kschwarz updated the diff for D103815: [ELF] Consider that NOLOAD sections should be placed in a PT_LOAD segment.

Test formatting

Tue, Jun 8, 3:27 AM · Restricted Project

Mon, Jun 7

kschwarz requested review of D103815: [ELF] Consider that NOLOAD sections should be placed in a PT_LOAD segment.
Mon, Jun 7, 7:48 AM · Restricted Project

Tue, May 25

kschwarz added inline comments to D101947: GlobalISel: Split ValueHandler into assignment and emission classes.
Tue, May 25, 6:00 AM · Restricted Project

Mar 1 2021

kschwarz added a comment to D97635: GlobalISel: Move splitToValueTypes to generic code.

Is there a plan to eventually get rid of the EVTs in call lowering and directly work with the LLVM IR Type?
Our downstream target needs special handling for pointer arguments, but unfortunately ComputeValueVTs loses the information about pointerness.
We solved this by directly operating on the LLVM IR type, although we do not handle vectors yet, which makes this a bit simpler

Mar 1 2021, 3:52 AM · Restricted Project

Jan 15 2021

kschwarz updated the diff for D89100: [GlobalISel] Look through truncs and extends in narrowScalarShift.

Adapt to new API of getConstantVRegValWithLookThrough, rebase

Jan 15 2021, 4:30 AM · Restricted Project

Oct 16 2020

kschwarz committed rG6030a075164c: Fix hidden-redecls.m test for some environments (authored by kschwarz).
Fix hidden-redecls.m test for some environments
Oct 16 2020, 12:51 AM
kschwarz closed D89453: Fix hidden-redecls.m test for some environments.
Oct 16 2020, 12:51 AM · Restricted Project

Oct 15 2020

kschwarz abandoned D89480: [GlobalISel][Legalizer] Implement lower action for G_FSHL/G_FSHR.

Duplicate D76500

Oct 15 2020, 11:34 AM · Restricted Project
kschwarz added a comment to D89453: Fix hidden-redecls.m test for some environments.

Yes, I'll commit it tomorrow, thanks for the review @akyrtzi!

Oct 15 2020, 11:21 AM · Restricted Project
kschwarz requested review of D89480: [GlobalISel][Legalizer] Implement lower action for G_FSHL/G_FSHR.
Oct 15 2020, 9:13 AM · Restricted Project
kschwarz requested review of D89453: Fix hidden-redecls.m test for some environments.
Oct 15 2020, 3:04 AM · Restricted Project

Oct 12 2020

kschwarz added inline comments to D89100: [GlobalISel] Look through truncs and extends in narrowScalarShift.
Oct 12 2020, 11:54 AM · Restricted Project
kschwarz committed rG734112343917: [GlobalISel][KnownBits] Early return on out of bound shift amounts (authored by kschwarz).
[GlobalISel][KnownBits] Early return on out of bound shift amounts
Oct 12 2020, 9:39 AM
kschwarz closed D89232: [GlobalISel][KnownBits] Early return on out of bound shift amounts.
Oct 12 2020, 9:39 AM · Restricted Project
kschwarz updated the diff for D89232: [GlobalISel][KnownBits] Early return on out of bound shift amounts.

Address review comments

Oct 12 2020, 8:39 AM · Restricted Project
kschwarz added a comment to D89100: [GlobalISel] Look through truncs and extends in narrowScalarShift.

The code asserting in GISelKnownBits is probably broken. An out of bounds shift is not illegal IR

Oct 12 2020, 4:28 AM · Restricted Project
kschwarz requested review of D89232: [GlobalISel][KnownBits] Early return on out of bound shift amounts.
Oct 12 2020, 4:22 AM · Restricted Project

Oct 9 2020

kschwarz requested review of D89100: [GlobalISel] Look through truncs and extends in narrowScalarShift.
Oct 9 2020, 1:02 AM · Restricted Project

Aug 20 2020

kschwarz committed rG7497b861f496: [GlobalISel][IRTranslator] Support PHI instructions in landingpad blocks (authored by kschwarz).
[GlobalISel][IRTranslator] Support PHI instructions in landingpad blocks
Aug 20 2020, 1:50 AM
kschwarz closed D86141: [GlobalISel][IRTranslator] Support PHI instructions in landingpad blocks.
Aug 20 2020, 1:50 AM · Restricted Project

Aug 19 2020

kschwarz added inline comments to D86141: [GlobalISel][IRTranslator] Support PHI instructions in landingpad blocks.
Aug 19 2020, 1:53 AM · Restricted Project

Aug 18 2020

kschwarz requested review of D86141: [GlobalISel][IRTranslator] Support PHI instructions in landingpad blocks.
Aug 18 2020, 7:11 AM · Restricted Project

Aug 13 2020

kschwarz added a comment to D85199: GlobalISel: Add generic instructions for memory intrinsics.

The problem we have is that some LLVM-IR passes introduce calls to llvm.memcpy.p0i8.p0i8.i64, even though our native pointer size is 32-bits. Since it turned out that fixing this in LLVM is quite invasive, we currently work around this problem by truncating the size argument to 32-bits before calling createMemLibcall.

You would have to deal with this whether passes introduce this IR or not, unless we make it a verifier error to deviate from the pointer size (which would be inconsistent with every other pointer sized integer operand, although I think this is pointless)

I'm thinking the IRTranslator should be responsible for this clamp, and the machine verifier should enforce the size of the length type. I'm not sure why we don't do this for G_INTTOPTR/G_PTRTOINT; I feel like the fact these aren't required to match the pointer size is a holdover from when the DataLayout was optional

Aug 13 2020, 7:20 AM · Restricted Project

Aug 4 2020

kschwarz added a comment to D85199: GlobalISel: Add generic instructions for memory intrinsics.

The promotion gets inserted in the libcall lowering [...]

Aug 4 2020, 6:52 AM · Restricted Project
kschwarz added a comment to D85122: [GlobalISel][InlineAsm] Fix matching input constraint to physreg.

Either you can create a bug in Bugzilla (https://bugs.llvm.org/), asking for this revision to be merged to the release branch and mark it as a release blocker of the 11.0.0 release, or you can contact the release manager directly (hans@chromium.org).

Aug 4 2020, 3:25 AM · Restricted Project

Aug 3 2020

kschwarz accepted D85122: [GlobalISel][InlineAsm] Fix matching input constraint to physreg.

LGTM, might be worth to include this also for the 11.x release.

Aug 3 2020, 6:51 AM · Restricted Project

Jul 23 2020

kschwarz committed rG931488779f7e: [GlobalISel][InlineAsm] Add register class ID to the flags of register input… (authored by kschwarz).
[GlobalISel][InlineAsm] Add register class ID to the flags of register input…
Jul 23 2020, 4:35 AM
kschwarz closed D83763: [GlobalISel][InlineAsm] Add register class ID to the flags of register input operands.
Jul 23 2020, 4:35 AM · Restricted Project
kschwarz updated the diff for D83763: [GlobalISel][InlineAsm] Add register class ID to the flags of register input operands.

Rebase

Jul 23 2020, 3:55 AM · Restricted Project

Jul 14 2020

Herald added a project to D83763: [GlobalISel][InlineAsm] Add register class ID to the flags of register input operands: Restricted Project.
Jul 14 2020, 5:24 AM · Restricted Project

Jul 8 2020

kschwarz added a comment to D83390: [GlobalISel][InlineAsm] Extend input operands when register class size does not match type.

A similar issue (for tied input operands) is handled in https://reviews.llvm.org/D83384
The function introduced there should be extended to handle the vector case.

Jul 8 2020, 2:51 PM · Restricted Project
kschwarz added a comment to D83384: [GlobalISel][InlineAsm] Fix buildCopy for inputs.

we noticed that this extension is also missing for the non-tied register input operands. I added the opposite logic, i.e. truncating of output operands, but forgot about extending the inputs.
Would you mind adding that handling in this patch too, as it is basically the same?
If you feel like it should be in a separate commit, I can also provide a patch for it. Thanks!

Jul 8 2020, 5:14 AM · Restricted Project

Jun 10 2020

kschwarz added a comment to D76283: [IRBuilder] Use preferred target type for len argument of memory intrinsic functions.

I brought this to the mailing list (http://lists.llvm.org/pipermail/llvm-dev/2020-March/140032.html) but didn't get an answer there.

Jun 10 2020, 4:20 AM · Restricted Project, Restricted Project
kschwarz updated the diff for D76283: [IRBuilder] Use preferred target type for len argument of memory intrinsic functions.

Brining this up again

Jun 10 2020, 4:20 AM · Restricted Project, Restricted Project
kschwarz added a reviewer for D76283: [IRBuilder] Use preferred target type for len argument of memory intrinsic functions: arsenm.
Jun 10 2020, 4:20 AM · Restricted Project, Restricted Project
kschwarz abandoned D77535: [GlobalISel] Add extended inline assembler support.

Yes, abandoning this in favor of https://reviews.llvm.org/D78316

Jun 10 2020, 1:36 AM · Restricted Project

May 27 2020

kschwarz committed rGf2fad3f703aa: [GlobalISel][InlineAsm] Add missing EarlyClobber flag to inline asm output… (authored by kschwarz).
[GlobalISel][InlineAsm] Add missing EarlyClobber flag to inline asm output…
May 27 2020, 3:12 AM
kschwarz closed D80467: [GlobalISel][InlineAsm] Add missing EarlyClobber flag to inline asm output operands.
May 27 2020, 3:12 AM · Restricted Project

May 23 2020

kschwarz created D80467: [GlobalISel][InlineAsm] Add missing EarlyClobber flag to inline asm output operands.
May 23 2020, 5:47 AM · Restricted Project

May 22 2020

kschwarz added a comment to D79955: [GlobalISel][InlineAsm] Add early return for memory inputs that need to be indirectified.

Hi @leonardchan, I'll take a look at the failure, thanks for the reproducer!

May 22 2020, 10:43 AM · Restricted Project

May 15 2020

kschwarz committed rG5425cdc3adf9: [GlobalISel][InlineAsm] Add early return for memory inputs that need to be… (authored by kschwarz).
[GlobalISel][InlineAsm] Add early return for memory inputs that need to be…
May 15 2020, 5:13 AM
kschwarz closed D79955: [GlobalISel][InlineAsm] Add early return for memory inputs that need to be indirectified.

Re-landed in 5425cdc3adf9998aeaf587d93417bd2f4f1373c9

May 15 2020, 5:13 AM · Restricted Project
kschwarz updated the diff for D79955: [GlobalISel][InlineAsm] Add early return for memory inputs that need to be indirectified.

The new check also triggered for memory clobbers, which we already handle.
I've moved the check further down, where we already check that it is an input operand.

May 15 2020, 3:02 AM · Restricted Project
kschwarz reopened D79955: [GlobalISel][InlineAsm] Add early return for memory inputs that need to be indirectified.

Re-opening for investigation

May 15 2020, 2:19 AM · Restricted Project

May 14 2020

kschwarz committed rG887dfeec53ad: [GlobalISel][InlineAsm] Add early return for memory inputs that need to be… (authored by kschwarz).
[GlobalISel][InlineAsm] Add early return for memory inputs that need to be…
May 14 2020, 2:43 PM
kschwarz closed D79955: [GlobalISel][InlineAsm] Add early return for memory inputs that need to be indirectified.
May 14 2020, 2:43 PM · Restricted Project
kschwarz updated the diff for D79955: [GlobalISel][InlineAsm] Add early return for memory inputs that need to be indirectified.

Add test extracted from pr68328.c

May 14 2020, 1:37 PM · Restricted Project
kschwarz added a comment to D78319: [GlobalISel][InlineAsm] Add support for basic input operand constraints.

I did not handle direct memory operands that need to be "indirectified" in this patch.
https://reviews.llvm.org/D79955 adds an early return for now so we don't run into the assertion while working on supporting that feature.

May 14 2020, 12:30 PM · Restricted Project
kschwarz created D79955: [GlobalISel][InlineAsm] Add early return for memory inputs that need to be indirectified.
May 14 2020, 12:30 PM · Restricted Project
kschwarz added a comment to D78319: [GlobalISel][InlineAsm] Add support for basic input operand constraints.

I'll have a look into it now. Thanks for letting me know!

May 14 2020, 11:23 AM · Restricted Project
kschwarz committed rG91063cf85a40: [GlobalISel][InlineAsm] Add support for basic input operand constraints (authored by kschwarz).
[GlobalISel][InlineAsm] Add support for basic input operand constraints
May 14 2020, 2:06 AM
kschwarz closed D78319: [GlobalISel][InlineAsm] Add support for basic input operand constraints.
May 14 2020, 2:05 AM · Restricted Project

May 12 2020

kschwarz updated the diff for D78319: [GlobalISel][InlineAsm] Add support for basic input operand constraints.

Change boolean constant extension logic to just query the type's bit width

May 12 2020, 7:29 AM · Restricted Project

May 11 2020

kschwarz updated the diff for D78319: [GlobalISel][InlineAsm] Add support for basic input operand constraints.

Formatting issues, add missing return false;

May 11 2020, 4:47 AM · Restricted Project
kschwarz added inline comments to D78319: [GlobalISel][InlineAsm] Add support for basic input operand constraints.
May 11 2020, 4:47 AM · Restricted Project

May 9 2020

kschwarz added inline comments to D78319: [GlobalISel][InlineAsm] Add support for basic input operand constraints.
May 9 2020, 2:05 AM · Restricted Project

May 8 2020

kschwarz added inline comments to D78319: [GlobalISel][InlineAsm] Add support for basic input operand constraints.
May 8 2020, 1:58 PM · Restricted Project
kschwarz updated the diff for D78319: [GlobalISel][InlineAsm] Add support for basic input operand constraints.

Rebase

May 8 2020, 1:34 AM · Restricted Project

May 7 2020

kschwarz updated the diff for D78319: [GlobalISel][InlineAsm] Add support for basic input operand constraints.

Address review comments

May 7 2020, 6:12 AM · Restricted Project
kschwarz added inline comments to D78319: [GlobalISel][InlineAsm] Add support for basic input operand constraints.
May 7 2020, 6:12 AM · Restricted Project

May 6 2020

kschwarz committed rGe82b0e9a8e85: [GlobalISel][InlineAsm] Add support for basic output operand constraints (authored by kschwarz).
[GlobalISel][InlineAsm] Add support for basic output operand constraints
May 6 2020, 1:35 AM
kschwarz closed D78318: [GlobalISel][InlineAsm] Add support for basic output operand constraints.
May 6 2020, 1:35 AM · Restricted Project

May 5 2020

kschwarz added a comment to D78318: [GlobalISel][InlineAsm] Add support for basic output operand constraints.

@arsenm, is this good to go now?

May 5 2020, 1:02 AM · Restricted Project

Apr 27 2020

kschwarz updated the diff for D78318: [GlobalISel][InlineAsm] Add support for basic output operand constraints.

Add regbank-select test.

Apr 27 2020, 2:38 AM · Restricted Project
kschwarz added inline comments to D78318: [GlobalISel][InlineAsm] Add support for basic output operand constraints.
Apr 27 2020, 2:38 AM · Restricted Project

Apr 24 2020

kschwarz updated the diff for D78318: [GlobalISel][InlineAsm] Add support for basic output operand constraints.

Hoist call to getRegisterInfo() and create local variable. Fix a few clangTidy issues

Apr 24 2020, 3:45 AM · Restricted Project
kschwarz added inline comments to D78318: [GlobalISel][InlineAsm] Add support for basic output operand constraints.
Apr 24 2020, 3:45 AM · Restricted Project

Apr 22 2020

kschwarz added inline comments to D78318: [GlobalISel][InlineAsm] Add support for basic output operand constraints.
Apr 22 2020, 8:38 AM · Restricted Project
kschwarz updated the diff for D78318: [GlobalISel][InlineAsm] Add support for basic output operand constraints.

Rebase & address more review comments

Apr 22 2020, 7:33 AM · Restricted Project
kschwarz added inline comments to D78318: [GlobalISel][InlineAsm] Add support for basic output operand constraints.
Apr 22 2020, 7:33 AM · Restricted Project

Apr 21 2020

kschwarz added inline comments to D78318: [GlobalISel][InlineAsm] Add support for basic output operand constraints.
Apr 21 2020, 9:10 AM · Restricted Project
kschwarz updated the diff for D78318: [GlobalISel][InlineAsm] Add support for basic output operand constraints.

Address some review comments

Apr 21 2020, 3:12 AM · Restricted Project

Apr 20 2020

kschwarz added inline comments to D78318: [GlobalISel][InlineAsm] Add support for basic output operand constraints.
Apr 20 2020, 11:21 AM · Restricted Project
kschwarz committed rG12030494fce2: [GlobalISel] Introduce InlineAsmLowering class (authored by kschwarz).
[GlobalISel] Introduce InlineAsmLowering class
Apr 20 2020, 6:26 AM
kschwarz closed D78316: [GlobalISel] Introduce InlineAsmLowering class.
Apr 20 2020, 6:25 AM · Restricted Project
kschwarz added inline comments to D78088: [MIR] Add comments to INLINEASM immediate flag MachineOperands.
Apr 20 2020, 3:43 AM · Restricted Project

Apr 17 2020

kschwarz updated the diff for D78318: [GlobalISel][InlineAsm] Add support for basic output operand constraints.

Address review comments

Apr 17 2020, 6:27 AM · Restricted Project
kschwarz added inline comments to D78318: [GlobalISel][InlineAsm] Add support for basic output operand constraints.
Apr 17 2020, 6:27 AM · Restricted Project

Apr 16 2020

kschwarz created D78319: [GlobalISel][InlineAsm] Add support for basic input operand constraints.
Apr 16 2020, 11:41 AM · Restricted Project
kschwarz created D78318: [GlobalISel][InlineAsm] Add support for basic output operand constraints.
Apr 16 2020, 11:41 AM · Restricted Project
kschwarz created D78316: [GlobalISel] Introduce InlineAsmLowering class.
Apr 16 2020, 11:41 AM · Restricted Project
kschwarz committed rG1a3e89aa2bd2: [MIR] Add comments to INLINEASM immediate flag MachineOperands (authored by kschwarz).
[MIR] Add comments to INLINEASM immediate flag MachineOperands
Apr 16 2020, 5:04 AM
kschwarz closed D78088: [MIR] Add comments to INLINEASM immediate flag MachineOperands.
Apr 16 2020, 5:03 AM · Restricted Project
kschwarz added inline comments to D78088: [MIR] Add comments to INLINEASM immediate flag MachineOperands.
Apr 16 2020, 5:03 AM · Restricted Project
kschwarz added a comment to D78088: [MIR] Add comments to INLINEASM immediate flag MachineOperands.

1a3e89aa2bd26ad05b25635457bad28f46427eeb

Apr 16 2020, 5:03 AM · Restricted Project

Apr 15 2020

kschwarz updated the diff for D78088: [MIR] Add comments to INLINEASM immediate flag MachineOperands.

Change assert to llvm_unreachable

Apr 15 2020, 8:44 AM · Restricted Project
kschwarz updated the diff for D78088: [MIR] Add comments to INLINEASM immediate flag MachineOperands.

Address review comments

Apr 15 2020, 5:59 AM · Restricted Project

Apr 14 2020

kschwarz added inline comments to D78088: [MIR] Add comments to INLINEASM immediate flag MachineOperands.
Apr 14 2020, 3:09 AM · Restricted Project
kschwarz edited reviewers for D78088: [MIR] Add comments to INLINEASM immediate flag MachineOperands, added: efriedma; removed: eli.friedman.
Apr 14 2020, 1:01 AM · Restricted Project
kschwarz added a comment to D78088: [MIR] Add comments to INLINEASM immediate flag MachineOperands.

I've thought about adding enum to string conversion functions to InlineAsm.h, which could be reused from both MachineInstr.cpp and TargetInstrInfo.cpp to avoid code duplication.
Would that be preferred here?

Apr 14 2020, 1:01 AM · Restricted Project
kschwarz created D78088: [MIR] Add comments to INLINEASM immediate flag MachineOperands.
Apr 14 2020, 1:01 AM · Restricted Project

Apr 6 2020

kschwarz added a comment to D77535: [GlobalISel] Add extended inline assembler support.

Is this just to feel out the general approach?

Apr 6 2020, 11:25 AM · Restricted Project
kschwarz created D77535: [GlobalISel] Add extended inline assembler support.
Apr 6 2020, 3:13 AM · Restricted Project

Mar 17 2020

kschwarz added a comment to D76283: [IRBuilder] Use preferred target type for len argument of memory intrinsic functions.

Correct, it will still miscompile even with this change.
I see two options: either 1) extend GlobalISel to select to the appropriate type, or 2) declare this as illegal LLVM IR in the first place.

Mar 17 2020, 9:05 AM · Restricted Project, Restricted Project
kschwarz updated subscribers of D76283: [IRBuilder] Use preferred target type for len argument of memory intrinsic functions.
Mar 17 2020, 7:25 AM · Restricted Project, Restricted Project