[analyzer] Add support for IE of keyboard and mouse navigation in HTML report

[ASDenysPetrov]

Summary

IE (Internet Explorer) throws errors while using key and mouse navigation through the error path tips. querySelectorAll method returns NodeList. NodeList belongs to browser API. IE doesn't have forEach among NodeList's methods. At the same time Array is a JavaScript object and can be used instead. The fix is in the converting NodeList into Array and keeps using forEach method as before.

Checked in IE11, Chrome and Opera.

[vsavchenko]

I'm not a big specialist in JS, so did you check it in other browsers?

[ASDenysPetrov]

@vsavchenko

I'm not a big specialist in JS, so did you check it in other browsers?

I've checked it in IE11, Chrome and Opera. It works.

[vsavchenko]

Great, thanks!

clang/lib/StaticAnalyzer/Core/HTMLDiagnostics.cpp

void HTMLDiagnostics::HighlightRange(Rewriter& R, FileID BugFileID,
   html::HighlightRange(R, InstantiationStart, E, HighlightStart, HighlightEnd);
 }
 
 StringRef HTMLDiagnostics::generateKeyboardNavigationJavascript() {
   return R"<<<(
 <script type='text/javascript'>
 var digitMatcher = new RegExp("[0-9]+");
 
+var querySelectorAllArray = function(selector) {
+  return Array.prototype.slice.call(
+    document.querySelectorAll(selector));
+}
+
 document.addEventListener("DOMContentLoaded", function() {
-    document.querySelectorAll(".PathNav > a").forEach(
+    querySelectorAllArray(".PathNav > a").forEach(
         function(currentValue, currentIndex) {
             var hrefValue = currentValue.getAttribute("href");
             currentValue.onclick = function() {
                 scrollTo(document.querySelector(hrefValue));
                 return false;
             };
         });
 });
 
 var findNum = function() {
     var s = document.querySelector(".selected");
     if (!s || s.id == "EndPath") {
         return 0;
     }
     var out = parseInt(digitMatcher.exec(s.id)[0]);
     return out;
 };
 
 var scrollTo = function(el) {
-    document.querySelectorAll(".selected").forEach(function(s) {
+    querySelectorAllArray(".selected").forEach(function(s) {
         s.classList.remove("selected");
     });
     el.classList.add("selected");
     window.scrollBy(0, el.getBoundingClientRect().top -
         (window.innerHeight / 2));
 }
 
 var move = function(num, up, numItems) {