Page MenuHomePhabricator

Replace separator in OpenMP variant name mangling.
ClosedPublic

Authored by LukasSommerTu on May 22 2020, 6:57 AM.

Details

Summary

Nvidia PTX does not allow . to appear in identifiers, so OpenMP variant mangling now uses $ to separate segments of the mangled name for variants of functions declared via declare variant.

Diff Detail

Event Timeline

LukasSommerTu created this revision.May 22 2020, 6:57 AM

Changes looks good to me.

We don't have tests that check the mangling, interesting (and my fault), should we add one?

Added a small test checking for functions with the correctly mangled name.

@jdoerfert: I've added a test. I kept it focused on the variants for NVPTX architecture (mangling is currently the same for all archs), let me know if that was what you had in mind.

jdoerfert accepted this revision.Jun 2 2020, 10:28 AM

LGTM. Thanks a lot!

This revision is now accepted and ready to land.Jun 2 2020, 10:28 AM

@jdoerfert: Can you please commit for me, I do not have commit access. Thanks!

This revision was automatically updated to reflect the committed changes.