This is an archive of the discontinued LLVM Phabricator instance.

[NFC] [PowerPC] Clean-up fast-math options in PPC tests
AbandonedPublic

Authored by qiucf on May 20 2020, 10:10 PM.

Details

Reviewers
steven.zhang
ZhangKang
jsji
nemanjai
Group Reviewers
Restricted Project
Summary

This patch removes use of these options:

  • --enable-no-infs-fp-math
  • --enable-no-nans-fp-math
  • --enable-no-signed-zeros-fp-math

They can be replaced by instruction-level fast-math flags.

Diff Detail

Event Timeline

qiucf created this revision.May 20 2020, 10:10 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 20 2020, 10:10 PM
jsji requested changes to this revision.May 21 2020, 6:53 AM

I don't think we should remove all the options from the tests.

Yes, they can be and should be replaced by instruction level flags, but the options are still supported.
So we shouldn't remove all of them from regression tests..
We can add or duplicate tests to include instruction level flags, but we should still keep testing options (until they are removed).

This revision now requires changes to proceed.May 21 2020, 6:53 AM
qiucf planned changes to this revision.May 24 2020, 8:36 AM

Keep existing fast-math cmd flags.

qiucf abandoned this revision.May 11 2021, 11:34 PM