Page MenuHomePhabricator
Differential D80233

[mlir][rocdl] Exposing buffer load/store intrinsic
ClosedPublic
Actions

Authored by jerryyin on May 19 2020, 1:18 PM.

Details

Reviewers
ftynse
whchung
rtaylor
Commits
rG9c53ac08de7c: [mlir][rocdl] Exposing buffer load/store intrinsic
Summary
  • Updated ROCDLOps tablegen
  • Added parsing and printing function for new intrinsic
  • Added unit tests

Diff Detail

Event Timeline

jerryyin created this revision.May 19 2020, 1:18 PM
Herald added a reviewer: ftynse. · View Herald TranscriptMay 19 2020, 1:18 PM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: llvm-commits, jurahul, Kayjukh and 14 others. · View Herald Transcript
jerryyin added reviewers: whchung, rtaylor.May 19 2020, 1:22 PM
whchung added a project: Restricted Project.May 19 2020, 1:56 PM
Harbormaster failed remote builds in B57255: Diff 265011!May 19 2020, 2:19 PM
jerryyin updated this revision to Diff 265045.May 19 2020, 2:35 PM

Fix lint error

Harbormaster completed remote builds in B57274: Diff 265045.May 19 2020, 4:00 PM
whchung added inline comments.May 20 2020, 7:14 AM
mlir/lib/Dialect/LLVMIR/IR/ROCDLDialect.cpp
37

@jerryyin It seems this printing function is only used by ROCDL_MubufLoadOp, but no one else.

jerryyin updated this revision to Diff 265247.May 20 2020, 7:52 AM

Inline printIntrinsic function

jerryyin marked 2 inline comments as done.May 20 2020, 7:57 AM
jerryyin added inline comments.
mlir/lib/Dialect/LLVMIR/IR/ROCDLDialect.cpp
37

I have inlined it in the tablegen.

jerryyin marked an inline comment as done.May 20 2020, 7:57 AM
Harbormaster completed remote builds in B57380: Diff 265247.May 20 2020, 9:16 AM
whchung accepted this revision.May 20 2020, 10:24 AM

Thanks!

This revision is now accepted and ready to land.May 20 2020, 10:24 AM
jerryyin closed this revision.May 21 2020, 7:27 AM

The CL has landed.

Revision Contents
Changeset List

PathSize
mlir/
include/
mlir/
Dialect/
LLVMIR/
46 lines
lib/
Dialect/
LLVMIR/
IR/
50 lines
Target/
LLVMIR/
5 lines
test/
Dialect/
LLVMIR/
23 lines
Target/
23 lines

Diff 265247

View Options

mlir/include/mlir/Dialect/LLVMIR/ROCDLOps.td

Loading...
View Options

mlir/lib/Dialect/LLVMIR/IR/ROCDLDialect.cpp

Loading...
View Options

mlir/lib/Target/LLVMIR/ConvertToROCDLIR.cpp

Loading...
View Options

mlir/test/Dialect/LLVMIR/rocdl.mlir

Loading...
View Options

mlir/test/Target/rocdl.mlir

Loading...