Page MenuHomePhabricator

[ELF] Make --trace-symbol track preempted shared definitions
ClosedPublic

Authored by MaskRay on Mon, May 18, 10:21 AM.

Details

Summary

Note, we still name a preempted SharedSymbol "shared definition",
instead of "reference" as printed by GNU ld. This difference should not matter.

// GNU ld
ld.bfd: t: definition of f@v1
ld.bfd: t.so: reference to f@v1

Diff Detail

Event Timeline

MaskRay created this revision.Mon, May 18, 10:21 AM
MaskRay updated this revision to Diff 264678.Mon, May 18, 10:22 AM

Delete an empty line

MaskRay updated this revision to Diff 264800.Mon, May 18, 11:42 PM
MaskRay edited the summary of this revision. (Show Details)

Simplify

psmith accepted this revision.Tue, May 19, 1:01 AM

LGTM.

lld/ELF/Symbols.cpp
716–717

I know some prefer an unrelated refactoring change to be split out. Maybe worth committing this separately as an NFC white space change.

This revision is now accepted and ready to land.Tue, May 19, 1:01 AM
MaskRay updated this revision to Diff 264936.Tue, May 19, 8:56 AM
MaskRay marked an inline comment as done.
MaskRay edited the summary of this revision. (Show Details)

Drop unneeded changes

This revision was automatically updated to reflect the committed changes.