This is an archive of the discontinued LLVM Phabricator instance.

[mlir] NFC - Fix OperationSupport.cpp::findNamedAttr
ClosedPublic

Authored by nicolasvasilache on May 17 2020, 12:25 PM.

Details

Summary

When NamedAttrList::get is called against a StringRef and the
entry is not present, the Identifier::operator== crashes.
Interestingly there seems to be no use of the NamedAttrList::get(StringRef) in
the codebase so far. A subsequent commit will introduce such a use.

Diff Detail

Event Timeline

Herald added a project: Restricted Project. · View Herald Transcript
ftynse accepted this revision.May 18 2020, 5:28 AM
This revision was not accepted when it landed; it landed in state Needs Review.May 18 2020, 6:57 AM
This revision was automatically updated to reflect the committed changes.