Page MenuHomePhabricator

[MLIR] Move JitRunner to live with ExecutionEngine

Authored by stephenneuendorffer on Wed, May 13, 12:04 PM.



The JitRunner library is logically very close to the execution engine,
and shares similar dependencies.

find -name "*.cpp" -exec sed -i "s/Support\/JitRunner/ExecutionEngine\/JitRunner/" "{}" \;

Diff Detail

Event Timeline

stephenneuendorffer edited the summary of this revision. (Show Details)
ftynse accepted this revision.Wed, May 13, 2:10 PM
ftynse added a subscriber: ftynse.

Please sort the includes alphabetically after renaming

This revision is now accepted and ready to land.Wed, May 13, 2:10 PM
mehdi_amini accepted this revision.Wed, May 13, 5:28 PM
mehdi_amini added inline comments.

This is off-topic, but this should be documented (the code you deleted had a comment to this end).
Isn't the JIT infra mostly coming from and so shouldn't be a "big dependency"?

stephenneuendorffer marked 2 inline comments as done.Thu, May 14, 2:46 PM
stephenneuendorffer added inline comments.

The same comment is now at the top of this file, intending to apply to all of the libraries here.

Your comment is true. I was thinking about trying to keep the size of binaries like mlir-opt down relative to mlir-cpu-runner. However once everything is linked into there's maybe not much to be gained. Probably worth experimenting with.

stephenneuendorffer marked an inline comment as done.
This revision was automatically updated to reflect the committed changes.