This is an archive of the discontinued LLVM Phabricator instance.

Differential D79795

Ensure that CMake tries to find Python3 before processing
ClosedPublic

Authored by ctetreau on May 12 2020, 10:55 AM.

Details

Reviewers
zturner
rnk
jmorse
chandlerc
Commits
rGf829ba60dadb: Ensure that CMake tries to find Python3 before processing
Summary

It is possible that CMake tries to process debuginfo-tests before any
attempt to find Python3. Ensure that CMake attempts to find it before
complaining that it doesn't exist.

Diff Detail

Event Timeline

ctetreau created this revision.May 12 2020, 10:55 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 12 2020, 10:55 AM
Herald added subscribers: llvm-commits, mgorny. · View Herald Transcript
ctetreau added reviewers: zturner, rnk, jmorse, chandlerc.May 12 2020, 11:02 AM
Harbormaster completed remote builds in B56459: Diff 263474.May 12 2020, 11:50 AM
rnk accepted this revision.May 12 2020, 2:17 PM

Grepping for this shows that it turns up in all the other top-level CMakeLists.txt. Sigh, duplication. lgtm.

This revision is now accepted and ready to land.May 12 2020, 2:17 PM
Closed by commit rGf829ba60dadb: Ensure that CMake tries to find Python3 before processing (authored by ctetreau). · Explain WhyMay 13 2020, 2:10 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
debuginfo-tests/
2 lines

Diff 263852

debuginfo-tests/CMakeLists.txt

# Debug Info tests. These tests invoke clang to generate programs with # Debug Info tests. These tests invoke clang to generate programs with
# various types of debug info, and then run those programs under a debugger # various types of debug info, and then run those programs under a debugger
# such as GDB or LLDB to verify the results. # such as GDB or LLDB to verify the results.
find_package(Python3 COMPONENTS Interpreter)
add_llvm_executable(check-gdb-llvm-support add_llvm_executable(check-gdb-llvm-support
llvm-prettyprinters/gdb/llvm-support.cpp llvm-prettyprinters/gdb/llvm-support.cpp
) )
target_link_libraries(check-gdb-llvm-support PRIVATE LLVMSupport) target_link_libraries(check-gdb-llvm-support PRIVATE LLVMSupport)
set(DEBUGINFO_TESTS_SOURCE_DIR ${CMAKE_CURRENT_SOURCE_DIR}) set(DEBUGINFO_TESTS_SOURCE_DIR ${CMAKE_CURRENT_SOURCE_DIR})
set(DEBUGINFO_TESTS_BINARY_DIR ${CMAKE_CURRENT_BINARY_DIR}) set(DEBUGINFO_TESTS_BINARY_DIR ${CMAKE_CURRENT_BINARY_DIR})
Show All 31 Lines