This is an archive of the discontinued LLVM Phabricator instance.

[mlir] Remove unnecessary DEPENDS for MLIRMlirOptMain
ClosedPublic

Authored by antiagainst on May 7 2020, 6:55 AM.

Reviewers

mehdi_amini
stephenneuendorffer

Commits

Summary

https://github.com/llvm/llvm-project/commit/c296d2dc53d5c11c
fixes the dependency issue by turning LINK_LIBS to PUBLIC.
These explicit DEPENDS are not needed anymore.

	Time	Test
	90 ms	LLVM.tools/llvm-isel-fuzzer::Unknown Unit Message ("")
	60 ms	LLVM.tools/llvm-isel-fuzzer::Unknown Unit Message ("")
	730 ms	LLVM.tools/llvm-isel-fuzzer::Unknown Unit Message ("")
	810 ms	LLVM.tools/llvm-isel-fuzzer::Unknown Unit Message ("")
	130 ms	LLVM.tools/llvm-isel-fuzzer::Unknown Unit Message ("")
		View Full Test Results (11 Failed)

This revision is now accepted and ready to land.May 7 2020, 8:52 AM

This revision was automatically updated to reflect the committed changes.

Path

Size

mlir/

tools/

mlir-opt/

4 lines

	Show All 35 Lines
	# opt-like tools only.			# opt-like tools only.
	add_mlir_library(MLIRMlirOptMain			add_mlir_library(MLIRMlirOptMain
	mlir-opt.cpp			mlir-opt.cpp

	EXCLUDE_FROM_LIBMLIR			EXCLUDE_FROM_LIBMLIR

	LINK_LIBS PUBLIC			LINK_LIBS PUBLIC
	${LIBS}			${LIBS}

	DEPENDS
	intrinsics_gen
	mlir-headers
	)			)

	add_llvm_tool(mlir-opt			add_llvm_tool(mlir-opt
	mlir-opt.cpp			mlir-opt.cpp

	DEPENDS			DEPENDS
	${LIBS}			${LIBS}
	)			)
	target_link_libraries(mlir-opt PRIVATE ${LIBS})			target_link_libraries(mlir-opt PRIVATE ${LIBS})
	llvm_update_compile_flags(mlir-opt)			llvm_update_compile_flags(mlir-opt)

	mlir_check_link_libraries(mlir-opt)			mlir_check_link_libraries(mlir-opt)