[OpenMP][NFC] Fix `not` sustitution in tests

[jdenny]

Summary

D78566 introduced a \bnot\b lit substitution in OpenMP test suites.
However, that would corrupt a command like
FileCheck -implicit-check-not or any file name like %t.not. We
could use lookbehind/lookahead assertions to avoid such cases, but
this patch switches to %not (suggested during the D78566 review) as
a safer option.

[jdoerfert]

LGTM.

[jdoerfert]

FWIW, if you feel confident you can just commit a patch like this one.

[jdenny]

Thanks!

[protze.joachim]

Is there any documentation available for not. It does not accept -h, it does not come with a man page. And it's not trivial to google for information on not.
How is not supposed to be used?

[jdenny]

In D79529#2064188, @protze.joachim wrote:

Is there any documentation available for not. It does not accept -h, it does not come with a man page. And it's not trivial to google for information on not.
How is not supposed to be used?

The best reference I have is: llvm/utils/not/not.cpp

openmp/libomptarget/deviceRTLs/nvptx/test/lit.cfg

config.substitutions.append(("%compile",
     "%clang %openmp_flags %flags %s -o %t"))
 
 config.substitutions.append(("%clangxx", config.test_cxx_compiler))
 config.substitutions.append(("%clang", config.test_c_compiler))
 config.substitutions.append(("%openmp_flags", config.test_openmp_flags))
 config.substitutions.append(("%flags", config.test_flags))
 
 config.substitutions.append(("%run", "%t"))
-config.substitutions.append((r"\bnot\b", config.libomptarget_not))
+config.substitutions.append(("%not", config.libomptarget_not))

openmp/libomptarget/test/lit.cfg

if libomptarget_target in config.libomptarget_system_targets:
             libomptarget_target, \
             "%clang-" + libomptarget_target + " %s -o %t-" + \
             libomptarget_target))
         config.substitutions.append(("%libomptarget-run-" + \
             libomptarget_target, \
             "%t-" + libomptarget_target))
         config.substitutions.append(("%libomptarget-run-fail-" + \
             libomptarget_target, \
-            "not %t-" + libomptarget_target))
+            "%not %t-" + libomptarget_target))
         config.substitutions.append(("%clangxx-" + libomptarget_target, \
             "%clangxx %openmp_flags %flags -fopenmp-targets=" + libomptarget_target))
         config.substitutions.append(("%clang-" + libomptarget_target, \
             "%clang %openmp_flags %flags -fopenmp-targets=" + libomptarget_target))
         config.substitutions.append(("%fcheck-" + libomptarget_target, \
             config.libomptarget_filecheck + " %s"))
     else:
         config.substitutions.append(("%libomptarget-compile-run-and-check-" + \
else:
             "echo ignored-command"))
         config.substitutions.append(("%fcheck-" + libomptarget_target, \
             "echo ignored-command"))
 
 config.substitutions.append(("%clangxx", config.test_cxx_compiler))
 config.substitutions.append(("%clang", config.test_c_compiler))
 config.substitutions.append(("%openmp_flags", config.test_openmp_flags))
 config.substitutions.append(("%flags", config.test_flags))
-config.substitutions.append((r"\bnot\b", config.libomptarget_not))
+config.substitutions.append(("%not", config.libomptarget_not))

openmp/runtime/test/lit.cfg

 config.substitutions.append(("%libomp-compile", \
     "%clang %openmp_flags %flags %s -o %t" + libs))
 config.substitutions.append(("%libomp-run", "%t"))
 config.substitutions.append(("%clangXX", config.test_cxx_compiler))
 config.substitutions.append(("%clang", config.test_c_compiler))
 config.substitutions.append(("%openmp_flags", config.test_openmp_flags))
 config.substitutions.append(("%flags", config.test_flags))
 config.substitutions.append(("%python", '"%s"' % (sys.executable)))
-config.substitutions.append((r"\bnot\b", config.test_not))
+config.substitutions.append(("%not", config.test_not))
 
 if config.has_ompt:
     config.substitutions.append(("FileCheck", "tee %%t.out | %s" % config.test_filecheck))
     config.substitutions.append(("%sort-threads", "sort -n -s"))
     if config.operating_system == 'Windows':
         # No such environment variable on Windows.
         config.substitutions.append(("%preload-tool", "true ||"))
         config.substitutions.append(("%no-as-needed-flag", "-Wl,--no-as-needed"))
     elif config.operating_system == 'Darwin':
         config.substitutions.append(("%preload-tool", "env DYLD_INSERT_LIBRARIES=%T/tool.so"))
         # No such linker flag on Darwin.
         config.substitutions.append(("%no-as-needed-flag", ""))
     else:
         config.substitutions.append(("%preload-tool", "env LD_PRELOAD=%T/tool.so"))
         config.substitutions.append(("%no-as-needed-flag", "-Wl,--no-as-needed"))

openmp/tools/archer/tests/lit.cfg

 config.substitutions.append(("%clang-archer", config.test_c_compiler))
 config.substitutions.append(("%openmp_flags", config.test_openmp_flags))
 config.substitutions.append(("%archer_flags", config.archer_flags))
 config.substitutions.append(("%flags", config.test_flags))
 config.substitutions.append(("%suppression", "env TSAN_OPTIONS='ignore_noninstrumented_modules=1'"))
 config.substitutions.append(("%deflake", os.path.join(os.path.dirname(__file__), "deflake.bash")))
 
 config.substitutions.append(("FileCheck", config.test_filecheck))
-config.substitutions.append((r"\bnot\b", config.test_not))
+config.substitutions.append(("%not", config.test_not))
 config.substitutions.append(("%sort-threads", "sort --numeric-sort --stable"))
 if config.operating_system == 'Windows':
     # No such environment variable on Windows.
     config.substitutions.append(("%preload-tool", "true ||"))
 elif config.operating_system == 'Darwin':
     config.substitutions.append(("%preload-tool", "env DYLD_INSERT_LIBRARIES=%T/tool.so"))
 else:
     config.substitutions.append(("%preload-tool", "env LD_PRELOAD=%T/tool.so"))