This is an archive of the discontinued LLVM Phabricator instance.

[flang] Response to Steve Scalpone's suggestion to improve a message
ClosedPublic

Authored by PeteSteinfeld on May 6 2020, 12:25 PM.

Diff Detail

Event Timeline

PeteSteinfeld created this revision.May 6 2020, 12:25 PM
Herald added a project: Restricted Project. · View Herald Transcript
PeteSteinfeld added a project: Restricted Project.May 6 2020, 12:26 PM
PeteSteinfeld accepted this revision.May 6 2020, 12:29 PM

This is a non-functional change.

This revision is now accepted and ready to land.May 6 2020, 12:29 PM
kiranchandramohan added inline comments.
flang/lib/Evaluate/check-expression.cpp
210

is there an extra "to"? Like should the message be "not allowed to reference variable"?

This revision was automatically updated to reflect the committed changes.
PeteSteinfeld reopened this revision.May 6 2020, 2:29 PM
PeteSteinfeld marked an inline comment as done.
PeteSteinfeld added inline comments.
flang/lib/Evaluate/check-expression.cpp
210

Ay yi yi! Thanks for catching this. I'll fix it.

This revision is now accepted and ready to land.May 6 2020, 2:29 PM
PeteSteinfeld accepted this revision.May 6 2020, 3:02 PM

I've pushed a fix to the problem that @kiranchandramohan pointed out.

This revision was automatically updated to reflect the committed changes.