This is an archive of the discontinued LLVM Phabricator instance.

Differential D79439

[mlir] Specify CMAKE_CXX_STANDARD to standalone dialect
ClosedPublic

Authored by antiagainst on May 5 2020, 11:56 AM.

Details

Reviewers
rriddle
Kayjukh
stephenneuendorffer
Commits
rG6f790f784ee4: [mlir] Specify CMAKE_CXX_STANDARD to standalone dialect
Summary

This addresses a compilation failure on GCC 5:

error: #error This file requires compiler and library support for the
ISO C++ 2011 standard. This support must be enabled with the -std=c++11
or -std=gnu++11 compiler options.
#error This file requires compiler and library support

Diff Detail

Event Timeline

antiagainst created this revision.May 5 2020, 11:56 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 5 2020, 11:56 AM
Herald added subscribers: llvm-commits, Kayjukh, frgossen and 11 others. · View Herald Transcript
antiagainst added a reviewer: Kayjukh.May 5 2020, 11:57 AM
rriddle accepted this revision.May 5 2020, 12:14 PM
This revision is now accepted and ready to land.May 5 2020, 12:14 PM
stephenneuendorffer accepted this revision.May 5 2020, 12:37 PM
Closed by commit rG6f790f784ee4: [mlir] Specify CMAKE_CXX_STANDARD to standalone dialect (authored by antiagainst). · Explain WhyMay 5 2020, 12:58 PM
This revision was automatically updated to reflect the committed changes.
Harbormaster completed remote builds in B55831: Diff 262187.May 5 2020, 1:31 PM

Revision Contents

PathSize
mlir/
examples/
standalone/
2 lines

Diff 262194

mlir/examples/standalone/CMakeLists.txt

Show All 9 Lines
endif() endif()
if(POLICY CMP0077) if(POLICY CMP0077)
cmake_policy(SET CMP0077 NEW) cmake_policy(SET CMP0077 NEW)
endif() endif()
project(standalone-dialect LANGUAGES CXX C) project(standalone-dialect LANGUAGES CXX C)
set(CMAKE_CXX_STANDARD 14 CACHE STRING "C++ standard to conform to")
find_package(MLIR REQUIRED CONFIG) find_package(MLIR REQUIRED CONFIG)
message(STATUS "Using MLIRConfig.cmake in: ${MLIR_DIR}") message(STATUS "Using MLIRConfig.cmake in: ${MLIR_DIR}")
message(STATUS "Using LLVMConfig.cmake in: ${LLVM_DIR}") message(STATUS "Using LLVMConfig.cmake in: ${LLVM_DIR}")
set(LLVM_RUNTIME_OUTPUT_INTDIR ${CMAKE_BINARY_DIR}/bin) set(LLVM_RUNTIME_OUTPUT_INTDIR ${CMAKE_BINARY_DIR}/bin)
set(LLVM_LIBRARY_OUTPUT_INTDIR ${CMAKE_BINARY_DIR}/lib) set(LLVM_LIBRARY_OUTPUT_INTDIR ${CMAKE_BINARY_DIR}/lib)
set(MLIR_BINARY_DIR ${CMAKE_BINARY_DIR}) set(MLIR_BINARY_DIR ${CMAKE_BINARY_DIR})
Show All 19 Lines