Page MenuHomePhabricator

[AMDGPU] Drop 16 bit subreg suffixes on print
ClosedPublic

Authored by rampitec on May 5 2020, 10:40 AM.

Details

Summary

We do not want to break asm syntax. These suffixes are
quite useful for debugging, so add an option to print
them. Right now it is NFC.

Diff Detail

Event Timeline

rampitec created this revision.May 5 2020, 10:40 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 5 2020, 10:40 AM
arsenm added inline comments.May 5 2020, 10:48 AM
llvm/lib/Target/AMDGPU/MCTargetDesc/AMDGPUInstPrinter.cpp
29–33

Could this be implemented as an assembler variant (e.g. AT&T vs. intel syntax?)

rampitec marked an inline comment as done.May 5 2020, 11:05 AM
rampitec added inline comments.
llvm/lib/Target/AMDGPU/MCTargetDesc/AMDGPUInstPrinter.cpp
29–33

Probably. I did not explore this.

rampitec marked an inline comment as done.May 5 2020, 11:28 AM
rampitec added inline comments.
llvm/lib/Target/AMDGPU/MCTargetDesc/AMDGPUInstPrinter.cpp
29–33

Actually it looks like an overkill. x86 has created a separate InstPrinter as dialects are quite different. Here the difference is really minimal, I doubt it worth it.

vpykhtin accepted this revision.May 6 2020, 1:37 AM
vpykhtin added a reviewer: dp.

LGTM.

llvm/lib/Target/AMDGPU/MCTargetDesc/AMDGPUInstPrinter.cpp
29–33

Is there AbsolutelyHidden attrubute?

This revision is now accepted and ready to land.May 6 2020, 1:39 AM
This revision was automatically updated to reflect the committed changes.