This is an archive of the discontinued LLVM Phabricator instance.

Differential D79370

[flang] update tools/f18 to use LLVM_LINK_COMPONENTS.
ClosedPublic

Authored by stephenneuendorffer on May 4 2020, 3:00 PM.

Details

Reviewers
DavidTruby
jdoerfert
Commits
rGf432154d1bcf: [flang] update tools/f18 to use LLVM_LINK_COMPONENTS.
Summary

This will prevent conflicts with libLLVM.so when using LLVM_LINK_LLVM_DYLIB=on.

Diff Detail

Event Timeline

stephenneuendorffer created this revision.May 4 2020, 3:00 PM
Herald added a reviewer: DavidTruby. · View Herald TranscriptMay 4 2020, 3:00 PM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: llvm-commits, mgorny. · View Herald Transcript
Harbormaster completed remote builds in B55704: Diff 261938.May 4 2020, 4:09 PM
ChinouneMehdi added a project: Restricted Project.May 4 2020, 9:01 PM
ChinouneMehdi added a subscriber: flang-commits.
Herald added a reviewer: jdoerfert. · View Herald TranscriptMay 4 2020, 9:01 PM
DavidTruby accepted this revision.May 5 2020, 12:25 AM

LGTM, thanks!

This revision is now accepted and ready to land.May 5 2020, 12:25 AM
Closed by commit rGf432154d1bcf: [flang] update tools/f18 to use LLVM_LINK_COMPONENTS. (authored by stephenneuendorffer). · Explain WhyMay 5 2020, 9:08 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
flang/
tools/
f18/
6 lines

Diff 262134

flang/tools/f18/CMakeLists.txt

set(LLVM_LINK_COMPONENTS
Support
)
add_flang_tool(f18 add_flang_tool(f18
dump.cpp dump.cpp
f18.cpp f18.cpp
) )
target_link_libraries(f18 target_link_libraries(f18
PRIVATE PRIVATE
FortranCommon FortranCommon
FortranParser FortranParser
FortranEvaluate FortranEvaluate
FortranSemantics FortranSemantics
FortranLower FortranLower
LLVMSupport
) )
set(MODULES set(MODULES
"ieee_arithmetic" "ieee_arithmetic"
"ieee_exceptions" "ieee_exceptions"
"ieee_features" "ieee_features"
"iso_c_binding" "iso_c_binding"
"iso_fortran_env" "iso_fortran_env"
▲ Show 20 Lines • Show All 43 Lines • Show Last 20 Lines