These libraries are distinct from other things in Analysis in that they
operate only on core IR concepts. This also simplifies dependencies
so that Dialect -> Analysis -> Parser -> IR. Previously, the parser depended
on portions of the the Analysis directory as well, which sometimes
caused issues with the way the cmake makefile generator discovers
dependencies on generated files during compilation.
Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
The files are marked as being added, but I would have expected something to mark the original locations as being moved/deleted.
mlir/examples/toy/Ch2/mlir/MLIRGen.cpp | ||
---|---|---|
17–18 | Can you fix these include orderings now? I would expect a run of clang-format to handle it. | |
mlir/include/mlir/IR/Dominance.h | ||
9 | MLIR_IR_ Now | |
mlir/include/mlir/IR/Verifier.h | ||
9 | MLIR_IR |
mlir/lib/IR/Verifier.cpp | ||
---|---|---|
31 | This one is an exception, generally if there is a matching header it should be included first. |
mlir/lib/IR/Verifier.cpp | ||
---|---|---|
31 | And I was confused by the fact that git clang-format did something wierd with it! |
Can you fix these include orderings now? I would expect a run of clang-format to handle it.